chore: rename erc20 action names#1162
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughRenames mainnet-related actions to ethereum, replaces admin bridge actions with public bridge entry points, removes fee/treasury handling, and standardizes token bridging to pass the full amount (TEXT → NUMERIC(78,0)) to chain-specific bridge functions. Wallet balance action renamed (mainnet → ethereum). Other existing actions remain unchanged. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant C as Client
participant DB as SQL Actions
participant SB as sepolia_bridge
participant MB as mainnet_bridge
rect rgba(230,245,255,0.6)
note over C,DB: Sepolia bridge path (new)
C->>DB: sepolia_bridge_tokens(amount: TEXT)
DB->>DB: CAST amount -> NUMERIC(78,0)
DB->>SB: bridge(amount_num)
SB-->>DB: result
DB-->>C: ack/result
end
rect rgba(240,255,230,0.6)
note over C,DB: Ethereum bridge path (renamed from mainnet)
C->>DB: ethereum_bridge_tokens(amount: TEXT)
DB->>DB: CAST amount -> NUMERIC(78,0)
DB->>MB: bridge(amount_num)
MB-->>DB: result
DB-->>C: ack/result
end
rect rgba(255,245,230,0.6)
note over C,DB: Wallet balance (renamed)
C->>DB: ethereum_wallet_balance(address)
DB->>MB: balance(address)
MB-->>DB: balance NUMERIC(78,0)
DB-->>C: balance
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Time Submission Status
|
Related Problem
resolves: https://github.com/trufnetwork/truf-network/issues/1203
Summary by CodeRabbit
New Features
Refactor
Chores