Skip to content

chore(erc20-bridge): protect admin actions #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MicBun merged 3 commits into from
Sep 10, 2025
Merged

chore(erc20-bridge): protect admin actions #1151

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d76804
feat: guard bridge admin actions
williamrusdyputra Sep 10, 2025
bcadc0c
Merge branch 'main' into feat/protect-admin-actions
williamrusdyputra Sep 10, 2025
a0b6d97
Merge branch 'main' into feat/protect-admin-actions
williamrusdyputra Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 84 additions & 0 deletions internal/migrations/erc20-bridge/001-actions.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,56 @@ CREATE OR REPLACE ACTION sepolia_wallet_balance($wallet_address TEXT) PUBLIC VIE
};

CREATE OR REPLACE ACTION sepolia_admin_lock_tokens($wallet_address TEXT, $amount TEXT) PUBLIC {
$lower_caller TEXT := LOWER(@caller);

-- Permission Check: Ensure caller has the 'system:erc20_bridge_writer' role.
$has_permission BOOL := false;
for $row in are_members_of('system', 'erc20_bridge_writer', ARRAY[$lower_caller]) {
if $row.wallet = $lower_caller AND $row.is_member {
$has_permission := true;
break;
}
}
if NOT $has_permission {
ERROR('Caller does not have the required system:erc20_bridge_writer role to lock tokens.');
}

sepolia_bridge.lock_admin($wallet_address, $amount::NUMERIC(78, 0));
};
Comment thread
williamrusdyputra marked this conversation as resolved.

CREATE OR REPLACE ACTION sepolia_admin_unlock_tokens($to_address TEXT, $amount TEXT) PUBLIC {
$lower_caller TEXT := LOWER(@caller);

-- Permission Check: Ensure caller has the 'system:erc20_bridge_writer' role.
$has_permission BOOL := false;
for $row in are_members_of('system', 'erc20_bridge_writer', ARRAY[$lower_caller]) {
if $row.wallet = $lower_caller AND $row.is_member {
$has_permission := true;
break;
}
}
if NOT $has_permission {
ERROR('Caller does not have the required system:erc20_bridge_writer role to unlock tokens.');
}

sepolia_bridge.unlock($to_address, $amount::NUMERIC(78, 0));
};

CREATE OR REPLACE ACTION sepolia_admin_issue_tokens($to_address TEXT, $amount TEXT) PUBLIC {
$lower_caller TEXT := LOWER(@caller);

-- Permission Check: Ensure caller has the 'system:erc20_bridge_writer' role.
$has_permission BOOL := false;
for $row in are_members_of('system', 'erc20_bridge_writer', ARRAY[$lower_caller]) {
if $row.wallet = $lower_caller AND $row.is_member {
$has_permission := true;
break;
}
}
if NOT $has_permission {
ERROR('Caller does not have the required system:erc20_bridge_writer role to issue tokens.');
}

sepolia_bridge.issue($to_address, $amount::NUMERIC(78, 0));
};

Expand All @@ -32,13 +74,55 @@ CREATE OR REPLACE ACTION mainnet_wallet_balance($wallet_address TEXT) PUBLIC VIE
};

CREATE OR REPLACE ACTION mainnet_admin_lock_tokens($wallet_address TEXT, $amount TEXT) PUBLIC {
$lower_caller TEXT := LOWER(@caller);

-- Permission Check: Ensure caller has the 'system:erc20_bridge_writer' role.
$has_permission BOOL := false;
for $row in are_members_of('system', 'erc20_bridge_writer', ARRAY[$lower_caller]) {
if $row.wallet = $lower_caller AND $row.is_member {
$has_permission := true;
break;
}
}
if NOT $has_permission {
ERROR('Caller does not have the required system:erc20_bridge_writer role to lock tokens.');
}

mainnet_bridge.lock_admin($wallet_address, $amount::NUMERIC(78, 0));
};

CREATE OR REPLACE ACTION mainnet_admin_unlock_tokens($to_address TEXT, $amount TEXT) PUBLIC {
$lower_caller TEXT := LOWER(@caller);

-- Permission Check: Ensure caller has the 'system:erc20_bridge_writer' role.
$has_permission BOOL := false;
for $row in are_members_of('system', 'erc20_bridge_writer', ARRAY[$lower_caller]) {
if $row.wallet = $lower_caller AND $row.is_member {
$has_permission := true;
break;
}
}
if NOT $has_permission {
ERROR('Caller does not have the required system:erc20_bridge_writer role to unlock tokens.');
}

mainnet_bridge.unlock($to_address, $amount::NUMERIC(78, 0));
};

CREATE OR REPLACE ACTION mainnet_admin_issue_tokens($to_address TEXT, $amount TEXT) PUBLIC {
$lower_caller TEXT := LOWER(@caller);

-- Permission Check: Ensure caller has the 'system:erc20_bridge_writer' role.
$has_permission BOOL := false;
for $row in are_members_of('system', 'erc20_bridge_writer', ARRAY[$lower_caller]) {
if $row.wallet = $lower_caller AND $row.is_member {
$has_permission := true;
break;
}
}
if NOT $has_permission {
ERROR('Caller does not have the required system:erc20_bridge_writer role to issue tokens.');
}

mainnet_bridge.issue($to_address, $amount::NUMERIC(78, 0));
};