Describe the issue
When using the Debug_WinLevelInstant shortcut (LCtrl+LShift+L), the music is not stopped, and proceeds to continue while in the front end.
When pressing Restart Mission from the options menu, the music also does not stop, and continues to play during the the intro video and briefing.
Expected behaviour
Music is only intended to play when in a level, when not showing an objective message (briefing, missing complete/failed). Even though Debug_WinLevelInstant is a debug shortcut, the game should still function as expected.
The Restart Mission music issue is slightly different, in that you could argue it sounds better to keep the current track playing even during the restarted second briefing. The same goes for music playing when pressing the Replay Objective button.
Steps to reproduce (A)
- Open up a level.
- Enable DebugComplete / AllowDebugKeys.
- Press the
Debug_WinLevelInstant shortcut (LCtrl+LShift+L).
- Music should continue to play while in the rewards screen and the rest of the front end.
Steps to reproduce (B)
- Open up a level.
- Open up the options menu.
- Press Restart Mission (or Replay Objective).
- Music should continue to play during the intro video and while briefing before starting the mission.
Additional information
- Time played this session: 3 minutes.
- Level: Driller Night!
- Game speed: 100%
- Graphics fix: dgVoodoo 2.55.4
- Using mods: None
Steps to fix
Possible solution (A)
Simply updating the music playing state in Lego_EndLevel (like is present in Objective_Update) should suffice.
Possible solution (B)
To fix the Restart Mission issue, update the music playing state in Level_Free.
To fix the issue with Replay Objective, the music playing state should be updated when calling Objective_SetStatus.
Describe the issue
When using the
Debug_WinLevelInstantshortcut (LCtrl+LShift+L), the music is not stopped, and proceeds to continue while in the front end.When pressing Restart Mission from the options menu, the music also does not stop, and continues to play during the the intro video and briefing.
Expected behaviour
Music is only intended to play when in a level, when not showing an objective message (briefing, missing complete/failed). Even though
Debug_WinLevelInstantis a debug shortcut, the game should still function as expected.The Restart Mission music issue is slightly different, in that you could argue it sounds better to keep the current track playing even during the restarted second briefing. The same goes for music playing when pressing the Replay Objective button.
Steps to reproduce (A)
Debug_WinLevelInstantshortcut (LCtrl+LShift+L).Steps to reproduce (B)
Additional information
Steps to fix
Possible solution (A)
Simply updating the music playing state in
Lego_EndLevel(like is present inObjective_Update) should suffice.Possible solution (B)
To fix the Restart Mission issue, update the music playing state in
Level_Free.To fix the issue with Replay Objective, the music playing state should be updated when calling
Objective_SetStatus.