fix(smalikit): detect existing appended method by declaration, not by reference

- Change append_method existence check to match .method declaration lines instead of plain substring search.

- Prevent false negatives when method signature appears only in invoke-direct references.

- Add regression test covering invoke-reference-only scenario to ensure helper method is still appended.

Author: toraidl

src/utils/smalikit.py

@@ -96,7 +96,11 @@ def _apply_append_method(self, content):
             self.log("[ERROR] append_method signature/method_block cannot be empty", Colors.FAIL)
             return content, False
 
-        if method_signature in content:
+        declaration_pattern = re.compile(
+            rf"^\s*\.method[^\n\r]*{re.escape(method_signature)}\s*$",
+            re.MULTILINE,
+        )
+        if declaration_pattern.search(content):
             return content, False
 
         normalized_block = method_block.replace("\\n", "\n").strip("\n")

tests/utils/test_smalikit.py

@@ -55,3 +55,33 @@ def test_append_method_skips_when_exists():
 
     assert patched is False
     assert new_content == content
+
+
+def test_append_method_does_not_treat_invoke_reference_as_existing_method():
+    signature = "getLocalizedValue(Ljava/lang/Object;)Ljava/lang/String;"
+    method_block = """
+.method private getLocalizedValue(Ljava/lang/Object;)Ljava/lang/String;
+    .locals 1
+    const-string v0, ""
+    return-object v0
+.end method
+""".strip()
+    content = """
+.class public Lcom/example/Test;
+.super Ljava/lang/Object;
+
+.method public demo(Ljava/lang/Object;)Ljava/lang/String;
+    .locals 1
+    invoke-direct {p0, p1}, Lcom/example/Test;->getLocalizedValue(Ljava/lang/Object;)Ljava/lang/String;
+    move-result-object v0
+    return-object v0
+.end method
+""".strip()
+
+    args = SmaliArgs(append_method=(signature, method_block))
+    patcher = SmaliKit(args, logger=logging.getLogger("test.smalikit"))
+
+    new_content, patched = patcher.process_content(content, "Test.smali")
+
+    assert patched is True
+    assert new_content.count(".method private getLocalizedValue") == 1