From 1177b97646171842b0b8ee01b68f4962790a2c74 Mon Sep 17 00:00:00 2001 From: Ewoud Kohl van Wijngaarden Date: Tue, 8 Dec 2020 19:11:46 +0100 Subject: [PATCH] Run pulpcore-manager check --deploy in acceptance Django has a checks framework that can detect problems in a deployment. It's also extensible and allows Pulp and plugin developers to add their own checks. This allows detection of misconfigurations. Some checks run implicitly before running certain commands but others don't for performance reasons. --deploy signals that a production setup is used, which enables more checks. https://docs.djangoproject.com/en/4.2/topics/checks/ --- spec/acceptance/basic_spec.rb | 5 +++++ spec/acceptance/plugins_spec.rb | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/spec/acceptance/basic_spec.rb b/spec/acceptance/basic_spec.rb index c50a275c..32ae9ff1 100644 --- a/spec/acceptance/basic_spec.rb +++ b/spec/acceptance/basic_spec.rb @@ -29,6 +29,11 @@ class { 'pulpcore': include_examples 'the default pulpcore application' + describe command('sudo -u pulp PULP_SETTINGS=/etc/pulp/settings.py pulpcore-manager check --deploy') do + its(:exit_status) { is_expected.to eq 0 } + its(:stderr) { is_expected.not_to match(/System check identified some issues:/) } + end + describe port(6379) do it { is_expected.to be_listening } end diff --git a/spec/acceptance/plugins_spec.rb b/spec/acceptance/plugins_spec.rb index e5e1fdf5..1808eb76 100644 --- a/spec/acceptance/plugins_spec.rb +++ b/spec/acceptance/plugins_spec.rb @@ -19,6 +19,11 @@ include_examples 'the default pulpcore application' + describe command('sudo -u pulp PULP_SETTINGS=/etc/pulp/settings.py pulpcore-manager check --deploy') do + its(:exit_status) { is_expected.to eq 0 } + its(:stderr) { is_expected.not_to match(/System check identified some issues:/) } + end + describe file('/etc/pulp/settings.py') do it { is_expected.to be_file } its(:content) { is_expected.to match(/^TOKEN_AUTH_DISABLED=True$/) }