From 1b8432af674d9a7b5aaa9f957ead320dfb4c7dba Mon Sep 17 00:00:00 2001 From: Emmanuel Dada Date: Wed, 2 Feb 2022 13:31:24 +0100 Subject: [PATCH 1/2] read the README file --- README.md | 14 ++++++++- assets/{ => css/assets}/backgroundpng.png | Bin assets/{ => css/assets}/bgimg1.png | Bin assets/{ => css/assets}/img1.png | Bin assets/{ => css/assets}/img2.png | Bin assets/{ => css/assets}/img3.png | Bin style.css => assets/css/style.css | 4 +-- main.js => assets/js/main.js | 0 index.html | 36 +++++++++++----------- 9 files changed, 33 insertions(+), 21 deletions(-) rename assets/{ => css/assets}/backgroundpng.png (100%) rename assets/{ => css/assets}/bgimg1.png (100%) rename assets/{ => css/assets}/img1.png (100%) rename assets/{ => css/assets}/img2.png (100%) rename assets/{ => css/assets}/img3.png (100%) rename style.css => assets/css/style.css (99%) rename main.js => assets/js/main.js (100%) diff --git a/README.md b/README.md index 2995e89..cecba7b 100644 --- a/README.md +++ b/README.md @@ -5,4 +5,16 @@ Mansory js: https://masonry.desandro.com/ Rellax js: https://dixonandmoe.com/rellax/ bootstrap icon: https://icons.getbootstrap.com/ -If there is anything i can do better, you can alawys say somwthing. Im active +If there is anything I can do better, you can alawys say something. I'm active. + +You have really done a great work @DeanSoftDev. Welldone!!! +I forked the repository, and added some changes to the code. You may want to merge to your branch. These are the changes below + +1. I noticed the images under the RECENT WORK AREA were not displaying. The reason was because you preceded the images' path with a forward slash. previous code :/assets/work/img1.png +current code: assets/work/img1.png *****notice the '/' before the assets in the previous code. +Now the images are displaying. + +2. I also created different folders for your js and css files. It is best practice that your javascript and css files should be well organized in separate folders. + +Great job :thumbsup: +Happy Coding!!! diff --git a/assets/backgroundpng.png b/assets/css/assets/backgroundpng.png similarity index 100% rename from assets/backgroundpng.png rename to assets/css/assets/backgroundpng.png diff --git a/assets/bgimg1.png b/assets/css/assets/bgimg1.png similarity index 100% rename from assets/bgimg1.png rename to assets/css/assets/bgimg1.png diff --git a/assets/img1.png b/assets/css/assets/img1.png similarity index 100% rename from assets/img1.png rename to assets/css/assets/img1.png diff --git a/assets/img2.png b/assets/css/assets/img2.png similarity index 100% rename from assets/img2.png rename to assets/css/assets/img2.png diff --git a/assets/img3.png b/assets/css/assets/img3.png similarity index 100% rename from assets/img3.png rename to assets/css/assets/img3.png diff --git a/style.css b/assets/css/style.css similarity index 99% rename from style.css rename to assets/css/style.css index 635b8da..d259c79 100644 --- a/style.css +++ b/assets/css/style.css @@ -34,7 +34,7 @@ *>* { box-sizing: border-box; - padding: 0; + padding: -10; margin: 0; } @@ -266,7 +266,7 @@ ul { body { width: 100%; - background: url('/assets/backgroundpng.png') no-repeat; + background: url('./assets/backgroundpng.png') no-repeat; background-size: cover; } diff --git a/main.js b/assets/js/main.js similarity index 100% rename from main.js rename to assets/js/main.js diff --git a/index.html b/index.html index 6c0b73a..7cf41e3 100644 --- a/index.html +++ b/index.html @@ -8,7 +8,7 @@ Digital Marketing - + @@ -77,7 +77,7 @@ business solutions
-

We merge imagination and technology to help thousand of

+

We merge imagination and technology to help thousands of

brands grow in an age of digital transformation

@@ -298,56 +298,56 @@

Mobile App

- digital experience + Digital experience

Some recent work
- we really proud of
+ we are really proud of

- img1 + img1

Photo Retouching

Branding
- img2 + img2

Apple Iphone

Branding
- img3 + img3

Yoga

Branding
- img4 + img4

Recent News

Branding
- img5 + img5

New Apps

Branding
- img6 + img6

Iphone 13pro

Branding
- img7 + img7

Share Market

Branding
- img8 + img8

Yoga

Branding
- img9 + img9

Yoga

Branding
@@ -367,7 +367,7 @@

Articles daily updates

- +
Category 6 hours ago @@ -378,7 +378,7 @@

Free advertising of your online business

- +
Category 6 hours ago @@ -389,7 +389,7 @@

Free advertising of your online business

- +
Category 6 hours ago @@ -484,7 +484,7 @@

Services

Newsletter

-

Subscribe out Newsletter to get the
+

Subscribe to our Newsletter to get the
latest news Updates

@@ -507,7 +507,7 @@

Newsletter

integrity="sha512-f5HTYZYTDZelxS7LEQYv8ppMHTZ6JJWglzeQmr0CVTS70vJgaJiIO15ALqI7bhsracojbXkezUIL+35UXwwGrQ==" crossorigin="anonymous" referrerpolicy="no-referrer"> - + From bc3da48662ce42fc2ab668f552ffe101ffc1c938 Mon Sep 17 00:00:00 2001 From: Emmanuel Dada <68846743+emmanuelthegeek@users.noreply.github.com> Date: Wed, 2 Feb 2022 13:51:06 +0100 Subject: [PATCH 2/2] Update README.md --- README.md | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index cecba7b..9e2f9e8 100644 --- a/README.md +++ b/README.md @@ -8,13 +8,9 @@ bootstrap icon: https://icons.getbootstrap.com/ If there is anything I can do better, you can alawys say something. I'm active. You have really done a great work @DeanSoftDev. Welldone!!! -I forked the repository, and added some changes to the code. You may want to merge to your branch. These are the changes below +I forked the repository, and added some changes to the code. You may want to merge to your branch. -1. I noticed the images under the RECENT WORK AREA were not displaying. The reason was because you preceded the images' path with a forward slash. previous code :/assets/work/img1.png -current code: assets/work/img1.png *****notice the '/' before the assets in the previous code. -Now the images are displaying. - -2. I also created different folders for your js and css files. It is best practice that your javascript and css files should be well organized in separate folders. +*************************** Great job :thumbsup: Happy Coding!!!