Message edit: triple click on a word should select the line, not the whole message

[kolayne]

Steps to reproduce

1. Start editing a message that contains multiple lines
2. In the edit area, triple click a word

Expected behaviour

The line that contains the word is selected (just like it happens when I triple click a word when writing a new message or when I triple click a word in a message in the chat view)

Actual behaviour

The whole message is selected

Operating system

Ubuntu 22.04, i3 version 4.20.1 // Arch Linux, i3 version 4.24

Version of Telegram Desktop

5.9 // 5.9.2 beta

Installation source

Static binary from official website

Crash ID

No response

Logs

No response

[kolayne]

If I triple-click the first word "Line" when composing a new message, this happens:

If I triple-click the first word "Line" when editing a message, this happens:

[kolayne]

It seems that Telegram Desktop assumes that the whole edited message is a single line/"paragraph". When, however, you add a new line while editing a message, the behavior for that line is as expected (triple-clicking the new line only selects that line)

[kolayne]

Found it. These lines from desktop-app/lib_ui@1d82347 are responsible for the problem (commenting them out fixes the issue). That appears very surprising: is that the intended behavior?

Anyway, should I reopen the issue in lib_ui?

[john-preston]

@kolayne Only with soft breaks the wysiwyg multiline blockquote editing works unfortunately. It could be possible to inspect whether the currently made change will end up in a blockquote or code block and use soft blocks only for them, but this was not done yet.

[kolayne]

@john-preston, that's what I did, I believe!

I've also double checked that with my fix (desktop-app/lib_ui#253) editing blockquotes and code blocks works, as well as exiting those blocks by inserting triple newline.

[SoeAung95]

@john-preston Please fix issue

[kolayne]

@john-preston, kind reminder that there is a fix for this issue, unreviewed

[john-preston]

@kolayne Did you try pasting a multi-line part of text inside a blockquote? I feel like it will break the blockquote (because you insert a text without tags, but you insert it into a blockquote), while my current code doesn't break it.

[kolayne]

@john-preston, indeed 😔

How would you suggest to fix that? Is there a routine that handles pasted text, which we could use to fix line breaks before text is pasted?