Artifact install plugin does not update an already installed package

[psss]

When a required package is already installed on the system, the artifact install plugin does not update or replace it and fails. Here's a simple reproducer:

/plan:
    discover:
        how: fmf
    provision:
        how: container
        image: fedora:43
    prepare:
        how: artifact
        provide: koji.build:2971867
    execute:
        how: tmt

/test:
    test: rpm -q vim-minimal
    require: vim-minimal

This is caused by the rpm -q check causing the install command to be completely skipped. But even if we drop the check, which is one of the solutions proposed in #4421, dnf5 install would just report the package is already installed and do nothing.

    prepare task #3: requires on default-0
    how: install
    summary: Install required packages
    name: requires
    order: 70
    where: default-0
    package: 1 package requested
        vim-minimal
        cmd: false || dnf5 install -y  vim-minimal
        stderr: Updating and loading repositories:
        stderr:  tmt-artifact-shared                    100% |   2.5 MiB/s |  10.2 KiB |  00m00s
        stderr: Repositories loaded.
        stderr: Package "vim-minimal-2:9.2.390-1.fc43.x86_64" is already installed.
        stdout: Nothing to do.
        stderr: 

    prepare task #4: verify-artifact-packages on default-0
    how: verify-installation
    summary: Verify test requirement packages were installed from the correct artifact repositories
    name: verify-artifact-packages
    order: 79
    1 package
        cmd: dnf5 repoquery --installed --queryformat '%{name} %{from_repo}\n' vim-minimal
        stdout: vim-minimal 4dc5ee694bfc47f9bbc228ba4d3c714d
    Package source verification failed for: vim-minimal
report
    how: display
    order: 50
    prepare
        ..:..:.. fail verify-artifact-packages / vim-minimal
            Note: Package 'vim-minimal': expected repo 'tmt-artifact-shared', actual '4dc5ee694bfc47f9bbc228ba4d3c714d'.

[LecrisUT]

Paraphrasing my reply from the other thread:

Ideally we want to avoid the dance of uninstall-downgrade-install-upgrade that testing-farm used. Afaik the only reliable way is to explicitly specify the nvr (and --from-repo would help disambiguate) in the dnf install. It would not resolve the case if the same nvr is installed, but that should be quite rare and the verify would catch that at least.

If there are other experimentation that other have done, would be good to add to this.

[tcornell-bus]

From the hacking session:

1. dnf install/dnf update always

• but it would not work if we want to reproduce the previous run

2. define a limited set of precise use cases that we will support

• Add test cases for these use cases, upgrade, downgrade, make a list

We are going with option 2 for now. @vaibhavdaren and @LecrisUT will work on list of test cases

Get in touch with dnf guys and see if they have suggestions