Merge pull request #8295 from systeminit/jobelenus/linting-rules

jobelenus · web-flow · commit 5c86e59e2fca · 2026-01-21T23:35:35.000Z
Proposal: Changing some linting rules, making some fixes
diff --git a/app/web/eslint.config.ts b/app/web/eslint.config.ts
@@ -74,9 +74,7 @@ export default defineConfigWithVueTs(
       // dont want this
       "@typescript-eslint/consistent-type-imports": 0,
       "import/named": 0,
-
-      // warning on this because we have some shenanigans where it is a promise but a literal `await` is not present
-      "@typescript-eslint/require-await": "warn",
+      "@typescript-eslint/require-await": 0,
 
       // "prettier/prettier": "warn",
       "@typescript-eslint/quotes": 0,
@@ -103,10 +101,11 @@ export default defineConfigWithVueTs(
       "no-await-in-loop": 0,
       "no-lonely-if": 0,
       "@typescript-eslint/no-unused-vars": [
-        "warn",
+        "error",
         {
           argsIgnorePattern: "^_|^(response)$",
           varsIgnorePattern: "^_|^(props|emit)$",
+          caughtErrorsIgnorePattern: "^_",
         },
       ],
       "@typescript-eslint/return-await": 0,
@@ -116,7 +115,7 @@ export default defineConfigWithVueTs(
       // curly: ["error", "multi-line"],
       // "brace-style": "error",
       "max-len": [
-        "warn", // just a warning since prettier will enforce
+        "off", // prettier will enforce
         120,
         2,
         {
@@ -167,9 +166,9 @@ export default defineConfigWithVueTs(
       "@typescript-eslint/no-shadow": 0,
       "guard-for-in": 0,
 
+      "no-console": "error",
       // some rules to downgrade to warning while developing --------------------
       // useful so things dont crash when code is temporarily commented out
-      "no-console": "warn",
       "@typescript-eslint/no-empty-function": "warn",
       "no-debugger": "warn",
       "no-alert": "warn",
@@ -192,6 +191,12 @@ export default defineConfigWithVueTs(
       // useful while debugging and commenting things out, otherwise gets automatically changed from let to const
       // "no-autofix/prefer-const": "warn",
 
+      // not clear to me why we have these problems
+      "import/no-named-as-default": 0,
+      "import/no-named-as-default-member": 0,
+
+      "@typescript-eslint/no-empty-function": 0,
+
       "vue/block-order": [
         "error",
         {
diff --git a/app/web/src/components/CachedAppNotification.vue b/app/web/src/components/CachedAppNotification.vue
@@ -54,7 +54,7 @@ async function check() {
     if (runningHash && latestHash !== runningHash) {
       openModal();
     }
-  } catch (err) {
+  } catch (_err) {
     // local dev errors here because the manifest file doesn't exist
     stopInterval();
   }
diff --git a/app/web/src/newhotness/FuncRunDetails.vue b/app/web/src/newhotness/FuncRunDetails.vue
@@ -289,7 +289,7 @@ const functionCode = computed<string>(() => {
   try {
     const decodedCode = atob(funcRun.value.functionCodeBase64);
     return decodedCode;
-  } catch (e) {
+  } catch (_e) {
     return "// Error decoding function code";
   }
 });
@@ -300,7 +300,7 @@ const argsJson = computed<string>(() => {
 
   try {
     return JSON.stringify(funcRun.value.functionArgs, null, 2);
-  } catch (e) {
+  } catch (_e) {
     return "// Error formatting arguments";
   }
 });
@@ -311,7 +311,7 @@ const resultJson = computed<string>(() => {
 
   try {
     return JSON.stringify(funcRun.value.resultValue, null, 2);
-  } catch (e) {
+  } catch (_e) {
     return "// Error formatting result";
   }
 });
diff --git a/app/web/src/newhotness/LatestFuncRunDetails.vue b/app/web/src/newhotness/LatestFuncRunDetails.vue
@@ -104,7 +104,7 @@ const functionCode = computed(() => actionDetailQuery.data.value?.code);
 const argsJson = computed(() => {
   try {
     return JSON.stringify(actionDetailQuery.data.value?.args, null, 2);
-  } catch (e) {
+  } catch (_e) {
     return "// Error formatting arguments";
   }
 });
diff --git a/app/web/src/newhotness/Review.vue b/app/web/src/newhotness/Review.vue
@@ -971,7 +971,7 @@ const restoreComponent = async () => {
     await sleep(1000);
     const result = await restoreComponents([selectedComponent.value.id]);
     restoreComponentStatus.value = result.success ? "succeeded" : undefined;
-  } catch (e) {
+  } catch (_e) {
     restoreComponentStatus.value = undefined;
   }
 };
diff --git a/app/web/src/newhotness/StatusPanel.vue b/app/web/src/newhotness/StatusPanel.vue
@@ -88,7 +88,7 @@ const STATUS_PANEL_KEY = "statusPanel";
 realtimeStore.subscribe(STATUS_PANEL_KEY, `workspace/${ctx.workspacePk.value}`, [
   {
     eventType: "ChangeSetStatusChanged",
-    callback: async (data) => {
+    callback: (data) => {
       if (
         [ChangeSetStatus.Abandoned, ChangeSetStatus.Applied, ChangeSetStatus.Closed].includes(data.changeSet.status) &&
         data.changeSet.id !== ctx.headChangeSetId.value
@@ -102,7 +102,7 @@ realtimeStore.subscribe(STATUS_PANEL_KEY, `workspace/${ctx.workspacePk.value}`,
   },
   {
     eventType: "ManagementOperationsComplete",
-    callback: async (payload, meta) => {
+    callback: (payload, meta) => {
       if (!payload.requestUlid) return;
       const key = `management-${payload.requestUlid}`;
       if (superBucket[meta.change_set_id]?.[key]) {
@@ -113,7 +113,7 @@ realtimeStore.subscribe(STATUS_PANEL_KEY, `workspace/${ctx.workspacePk.value}`,
   },
   {
     eventType: "ManagementOperationsFailed",
-    callback: async (payload, meta) => {
+    callback: (payload, meta) => {
       // BUCKET ITEM -- ADD -- MANAGEMENT FUNCS
       const key = `management-${payload.requestUlid}`;
       let bucket = superBucket[meta.change_set_id];
@@ -126,7 +126,7 @@ realtimeStore.subscribe(STATUS_PANEL_KEY, `workspace/${ctx.workspacePk.value}`,
   },
   {
     eventType: "ManagementOperationsInProgress",
-    callback: async (payload, meta) => {
+    callback: (payload, meta) => {
       // BUCKET ITEM -- ADD -- MANAGEMENT FUNCS
       const key = `management-${payload.requestUlid}`;
       let bucket = superBucket[meta.change_set_id];
diff --git a/app/web/src/newhotness/Workspace.vue b/app/web/src/newhotness/Workspace.vue
@@ -146,7 +146,7 @@
 <script lang="ts" setup>
 import { useRoute, useRouter } from "vue-router";
 import clsx from "clsx";
-import { computed, onMounted, onBeforeUnmount, onBeforeMount, ref, provide, watch, Ref, inject } from "vue";
+import { computed, onMounted, onBeforeMount, ref, provide, watch, Ref, inject } from "vue";
 import * as _ from "lodash-es";
 import { useQuery, useQueryClient } from "@tanstack/vue-query";
 import { Span, trace } from "@opentelemetry/api";
@@ -173,7 +173,7 @@ import {
   startMouseEmitters,
   startKeyEmitter,
   startWindowResizeEmitter,
-  windowWidthReactive
+  windowWidthReactive,
 } from "./logic_composables/emitters";
 import { getUserPkFromToken, tokensByWorkspacePk } from "./logic_composables/tokens";
 import ComponentPage from "./ComponentDetails.vue";
diff --git a/app/web/src/newhotness/api_composables/func_run.test.ts b/app/web/src/newhotness/api_composables/func_run.test.ts
@@ -1,6 +1,5 @@
 import { describe, expect, test } from "vitest";
 import { funcRunStatus, FuncRun, FuncKind, FuncBackendKind, FuncBackendResponseType } from "./func_run";
-import { ManagementState } from "./management_func_job_state";
 
 /**
  * Creates a minimal FuncRun object for testing.
diff --git a/app/web/src/newhotness/logic_composables/rainbow_counter.ts b/app/web/src/newhotness/logic_composables/rainbow_counter.ts
@@ -26,7 +26,7 @@ export const useRainbow = (changeSetId: ComputedRef<ChangeSetId>) => {
        * When its > 0 the system is waiting for data
        */
       return { count: computed(() => queue?.size ?? 0) };
-    } catch (err) {
+    } catch (_err) {
       return { count: 0 };
     }
   });
diff --git a/app/web/src/newhotness/logic_composables/watched_form.ts b/app/web/src/newhotness/logic_composables/watched_form.ts
@@ -130,7 +130,7 @@ export const useWatchedForm = <Data extends Record<string, string>>(label: strin
           try {
             await onSubmit(props);
             hasSubmitted = true;
-          } catch (e) {
+          } catch (_e) {
             // TODO report errors and display on caller forms
             // Cancel the spinner and bifrosting on failure
             markComplete();
diff --git a/app/web/src/newhotness/nav/Collaborators.vue b/app/web/src/newhotness/nav/Collaborators.vue
@@ -71,7 +71,7 @@
 
 <script lang="ts" setup>
 import * as _ from "lodash-es";
-import { computed, onBeforeUnmount, onMounted, ref } from "vue";
+import { computed, ref } from "vue";
 import { SiSearch, Icon } from "@si/vue-lib/design-system";
 import clsx from "clsx";
 import { useRoute, useRouter } from "vue-router";
diff --git a/app/web/src/newhotness/nav/Notifications.vue b/app/web/src/newhotness/nav/Notifications.vue
@@ -39,7 +39,7 @@
 
 <script setup lang="ts">
 import clsx from "clsx";
-import { computed, ref, onMounted, onBeforeUnmount } from "vue";
+import { computed, ref } from "vue";
 import { Icon, PillCounter } from "@si/vue-lib/design-system";
 import { useQueries } from "@tanstack/vue-query";
 import { ChangeSetId, ChangeSet, ChangeSetStatus } from "@/api/sdf/dal/change_set";
diff --git a/app/web/src/store/auth.store.ts b/app/web/src/store/auth.store.ts
@@ -329,7 +329,7 @@ export const useAuthStore = () => {
               },
             });
           }
-        } catch (error) {
+        } catch (_error) {
           // Silently fail - logout will still clear local state
         }
 
diff --git a/app/web/src/store/realtime/heimdall.ts b/app/web/src/store/realtime/heimdall.ts
@@ -320,17 +320,13 @@ db.getConnections().then((conns) => {
   });
 });
 
-const updateConnectionStatus: ConnStatusFn = async (
-  workspaceId: WorkspacePk,
-  connected: boolean,
-  noBroadcast?: boolean,
-) => {
+const updateConnectionStatus: ConnStatusFn = (workspaceId: WorkspacePk, connected: boolean, noBroadcast?: boolean) => {
   _wsConnections.value[workspaceId] = connected;
 
   // always update to connected
   if (connected) wsConnections.value[workspaceId] = connected;
 
-  await db.setConnections({ ..._wsConnections.value });
+  db.setConnections({ ..._wsConnections.value });
 
   // prevent blips in the UI from quick disconnect -> connect flips
   setTimeout(() => {
@@ -691,7 +687,7 @@ const fetchOpenChangeSets = async (workspaceId: WorkspacePk): Promise<WorkspaceM
       url: `v2/workspaces/${workspaceId}/change-sets`,
     });
     return resp.data;
-  } catch (err) {
+  } catch (_err) {
     return {
       name: "",
       id: "",
diff --git a/app/web/src/store/realtime/realtime.store.ts b/app/web/src/store/realtime/realtime.store.ts
@@ -325,7 +325,7 @@ export const useRealtimeStore = defineStore("realtime", () => {
       // toRebaseChangeSetId is HEAD / where merges are going into
       try {
         topics.push(`changeset/${eventData.toRebaseChangeSetId}`);
-      } catch (err) {
+      } catch (_err) {
         // do nothing
       }
     }
diff --git a/app/web/src/workers/types/dbinterface.ts b/app/web/src/workers/types/dbinterface.ts
@@ -43,7 +43,7 @@ export type UpdateFn = (
   noBroadcast?: boolean,
 ) => void;
 export type RainbowFn = (changeSetId: ChangeSetId, label: string, noBroadcast?: boolean) => void;
-export type LobbyExitFn = (workspacePk: string, changeSetId: string, noBroadcast?: boolean) => void;
+export type LobbyExitFn = (workspacePk: string, changeSetId: string, noBroadcast?: boolean) => Promise<void>;
 
 export type MjolnirBulk = Array<{
   kind: EntityKind;
diff --git a/app/web/src/workers/webworker.mess.ts b/app/web/src/workers/webworker.mess.ts
@@ -1412,7 +1412,7 @@ async function go() {
   db.addListenerInFlight(Comlink.proxy(() => {}));
   db.addListenerReturned(Comlink.proxy(() => {}));
   db.addAtomUpdated(Comlink.proxy(() => {}));
-  db.addListenerLobbyExit(Comlink.proxy(() => {}));
+  db.addListenerLobbyExit(Comlink.proxy(async () => {}));
   db.addConnStatusFn(Comlink.proxy(() => {}));
   await db.initDB(true);
   await db.migrate(true);
diff --git a/app/web/src/workers/webworker.perf.ts b/app/web/src/workers/webworker.perf.ts
@@ -1411,7 +1411,7 @@ async function go() {
   db.addListenerInFlight(Comlink.proxy(() => {}));
   db.addListenerReturned(Comlink.proxy(() => {}));
   db.addAtomUpdated(Comlink.proxy(() => {}));
-  db.addListenerLobbyExit(Comlink.proxy(() => {}));
+  db.addListenerLobbyExit(Comlink.proxy(async () => {}));
   db.addConnStatusFn(Comlink.proxy(() => {}));
   await db.initDB(true);
   await db.migrate(true);
diff --git a/app/web/src/workers/webworker.test.ts b/app/web/src/workers/webworker.test.ts
@@ -6,7 +6,6 @@ import {
   NOROW,
   WorkspacePatchBatch,
   AtomDocument,
-  OutgoingConnections,
   WorkspaceIndexUpdate,
   MessageKind,
 } from "@/workers/types/dbinterface";
@@ -5422,7 +5421,7 @@ async function go() {
   db.addListenerInFlight(Comlink.proxy(() => {}));
   db.addListenerReturned(Comlink.proxy(() => {}));
   db.addAtomUpdated(Comlink.proxy(() => {}));
-  db.addListenerLobbyExit(Comlink.proxy(() => {}));
+  db.addListenerLobbyExit(Comlink.proxy(async () => {}));
   db.addConnStatusFn(Comlink.proxy(() => {}));
   await db.initDB(true);
   await db.migrate(true);
diff --git a/app/web/src/workers/webworker.ts b/app/web/src/workers/webworker.ts
@@ -1204,7 +1204,7 @@ const handleWorkspacePatchMessage = async (db: Database, data: WorkspacePatchBat
         try {
           await initIndexAndChangeSet(db, data.meta, span);
           await updateChangeSetWithNewIndex(db, data.meta);
-        } catch (err) {
+        } catch (_err) {
           error("Failed to handle empty patch", data);
         }
         span.end();
@@ -1455,7 +1455,7 @@ const handlePatchOperations = async (
   for (const atom of atomsToInsert) {
     try {
       await postProcess(db, workspaceId, changeSetId, atom.kind, atom.doc, atom.id, indexChecksum, false, true);
-    } catch (err) {
+    } catch (_err) {
       error("Failed to post process atom", atom, error);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ async function check() {`
`54`	`54`	`if (runningHash && latestHash !== runningHash) {`
`55`	`55`	`openModal();`
`56`	`56`	`}`
`57`		`- } catch (err) {`
	`57`	`+ } catch (_err) {`
`58`	`58`	`// local dev errors here because the manifest file doesn't exist`
`59`	`59`	`stopInterval();`
`60`	`60`	`}`
Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ const functionCode = computed(() => actionDetailQuery.data.value?.code);`
`104`	`104`	`const argsJson = computed(() => {`
`105`	`105`	`try {`
`106`	`106`	`return JSON.stringify(actionDetailQuery.data.value?.args, null, 2);`
`107`		`- } catch (e) {`
	`107`	`+ } catch (_e) {`
`108`	`108`	`return "// Error formatting arguments";`
`109`	`109`	`}`
`110`	`110`	`});`
Original file line number	Diff line number	Diff line change
`@@ -971,7 +971,7 @@ const restoreComponent = async () => {`
`971`	`971`	`await sleep(1000);`
`972`	`972`	`const result = await restoreComponents([selectedComponent.value.id]);`
`973`	`973`	`restoreComponentStatus.value = result.success ? "succeeded" : undefined;`
`974`		`- } catch (e) {`
	`974`	`+ } catch (_e) {`
`975`	`975`	`restoreComponentStatus.value = undefined;`
`976`	`976`	`}`
`977`	`977`	`};`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ export const useRainbow = (changeSetId: ComputedRef<ChangeSetId>) => {`
`26`	`26`	`* When its > 0 the system is waiting for data`
`27`	`27`	`*/`
`28`	`28`	`return { count: computed(() => queue?.size ?? 0) };`
`29`		`- } catch (err) {`
	`29`	`+ } catch (_err) {`
`30`	`30`	`return { count: 0 };`
`31`	`31`	`}`
`32`	`32`	`});`