Merge pull request #86159 from slavapestov/slava/fix-issue-86118-6.3

[6.3] SILGen: Fix assert when emitting re-abstraction thunk in edge case involving opaque return type

Author: slavapestov

lib/SIL/IR/SILFunctionType.cpp

@@ -3426,7 +3426,9 @@ CanSILFunctionType swift::buildSILFunctionThunkType(
 
   if (!capturedEnvs.empty() ||
       expectedType->hasPrimaryArchetype() ||
-      sourceType->hasPrimaryArchetype()) {
+      sourceType->hasPrimaryArchetype() ||
+      (inputSubstType && inputSubstType->hasPrimaryArchetype()) ||
+      (outputSubstType && outputSubstType->hasPrimaryArchetype())) {
     // Get the existing generic signature.
     baseGenericSig = fn->getLoweredFunctionType()
         ->getInvocationGenericSignature();

test/SILGen/opaque_result_type_thunk.swift

@@ -0,0 +1,19 @@
+// RUN: %target-swift-emit-silgen %s
+
+// https://github.com/swiftlang/swift/issues/86118
+
+// The AST type of the thunk depends on the generic signature, but the
+// lowered type does not, because we can see the opaque return type's
+// underlying type from the expansion point, and it does not involve
+// type parameters. Make sure this does not cause us to assert.
+
+public struct G<T> {
+  public static func f(_: Any, _: Any) -> some Any {
+    return 123
+  }
+}
+
+public func g<T>(_: T) {
+  let fn: (Any, Any) -> _ = G<T>.f
+  let fn2: (Int, Int) -> _ = fn
+}