{ADD]

Author: gfcapalbo

auditlog_security/__manifest__.py

@@ -13,7 +13,6 @@
         "contacts",
     ],
     "data": [
-        "demo/auditlog_rule.xml",
         "views/auditlog_view.xml",
     ],
     "application": True,

auditlog_security/demo/auditlog_rule.xml

@@ -1,7 +1,7 @@
 # Copyright 2021 Therp B.V.
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
-from odoo import models, fields, api, modules, _
+from odoo import exceptions, models, fields, api, modules, _
 from odoo.addons.auditlog.models.rule import FIELDS_BLACKLIST
 
 
@@ -19,8 +19,22 @@ class AuditlogRule(models.Model):
     )
     all_fields = fields.Boolean(
             string="Publicly visible log lines for all fields",
+            readonly=True,
+            compute="compute_all_fields",
+            store=False,
             help="Check this field if you want this model to be visible by everyone")
 
+    @api.depends('field_ids')
+    def compute_all_fields(self):
+        for this in self.sudo():
+            this.all_fields = not bool(len(this.field_ids))
+
+    @api.onchange('model_id')
+    def onchange_model_id(self):
+        # if model changes we must wipe out all field ids
+        self.field_ids = False
+
+
 
     def get_field_ids_domain(self):
         """ note this solution will work only with a hardcoded design of models,
@@ -34,27 +48,26 @@ def get_field_ids_domain(self):
     def unlink(self):
         # if we delete auditlog rule, corresponding ir.rules are removed
         # TODO PROPOSAL: a warning here with detailed information?
+        to_delete = self.env["ir.rule"].with_context(auditlog_write=True).search(
+                [("auditlog_id", "=", self.ids)])
         res = super(AuditlogRule, self).unlink()
-        return (
-            res
-            and self.env["ir.rule"]
-            .with_context(auditlog_write=True)
-            .search([("auditlog_id", "in", self.ids)])
-            .unlink()
-        )
-
+        if res:
+            res = res and to_delete.unlink()
+        return res
 
     @api.model
     def create(self, vals):
         if 'group_ids' not in vals:
             # if group has been removed and no group specified ad base user default
             vals['group_ids'] = [(6, 0, [self.env.ref('base.group_user').id])]
-        if field_ids not in vals and  not vals.get('all_fields'):
+        if 'field_ids' not in vals and not vals.get('all_fields'):
             # this was done because of a 
             # bug in attrs={'required': [('all_fields', '!=', True}
-            raise exceptions.validationerror(
+            raise exceptions.ValidationError(
                 _("please specify fields to log or make all_fields true"))
-        return super(AuditlogRule, self).create(vals)
+        res = super(AuditlogRule, self).create(vals)
+        res.generate_rules()
+        return res
 
     @api.multi
     def write(self, vals):

auditlog_security/models/auditlog_rule.py

@@ -32,16 +32,15 @@ def create(self, values):
     def write(self, vals):
         if "auditlog_id" in vals and not self.env.context.get(
                 'auditlog_write'):
-            raise exceptions.validationerror(_("""Cannot change auditlog_id"""))
+            raise exceptions.ValidationError(_("""Cannot change auditlog_id"""))
         return super(IrRule, self).write(vals)
 
     @api.multi
     def unlink(self):
-        self.prevent_rule_mod()
         auditlog_write = self.env.context.get("auditlog_write")
         for this in self:
             if this.auditlog_id and not auditlog_write:
-                raise exceptions.validationerror(
+                raise exceptions.ValidationError(
                     _(
 
                     """

auditlog_security/models/ir_rule.py

@@ -49,13 +49,12 @@
                     <!-- in the domain are the blacklisted fields in auditlog they 
                     would be skipped anyway, so we repeat here to avoid incongruencies 
                     -->
-                    <field name="global_rule"/>
                     <field name="field_ids"
-                        domain="[('model_id', '=' , model_id),('name', 'not in', ['id', 'create_uid', 'create_date', 'write_uid', 'write_date','display_name', '__last_update']) ]"
-                        attrs="{'required' : [('global_rule', '!=', True)]}"/>
+                        domain="[('model_id', '=' , model_id),('name', 'not in', ['id', 'create_uid', 'create_date', 'write_uid', 'write_date','display_name', '__last_update']) ]"/>
                 </group>
                 <group>
                     <field name="group_ids" /> 
+                    <field name="all_fields"/>
                 </group>
             </xpath>