Skip to content

style: avoid using star imports#438

Merged
vbarua merged 2 commits into
substrait-io:mainfrom
nielspardon:par-import-star
Jul 23, 2025
Merged

style: avoid using star imports#438
vbarua merged 2 commits into
substrait-io:mainfrom
nielspardon:par-import-star

Conversation

@nielspardon
Copy link
Copy Markdown
Member

This makes it easier to understand which types/constants/methods are actually used in the code.

@bestbeforetoday
Copy link
Copy Markdown
Member

The latest version of the Spotless plugin has a removeWildcardImports() step. Probably this change should include adoption of that Spotless capability; otherwise later changes will just end up regressing these changes and/or adding more wildcard imports.

@nielspardon
Copy link
Copy Markdown
Member Author

The latest version of the Spotless plugin has a removeWildcardImports() step. Probably this change should include adoption of that Spotless capability; otherwise later changes will just end up regressing these changes and/or adding more wildcard imports.

Good catch. I wasn't aware they had this now in Spotless.

@nielspardon
Copy link
Copy Markdown
Member Author

I rebased on latest main and pushed an additional commit upgrading spotless and enabling the removeWildcardImports option. The Spotless update did trigger some reformatting of existing code.

Copy link
Copy Markdown
Member

@bestbeforetoday bestbeforetoday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me.

It would be nice to figure out if we will proceed with #433 before merging this since it will introduce a fourth round of merge conflicts with that PR.

Signed-off-by: Niels Pardon <par@zurich.ibm.com>
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
Copy link
Copy Markdown
Member

@vbarua vbarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated these in the past as I've seen them, so it's great that we can just enforce this via Spotless.

@vbarua vbarua merged commit d006fbc into substrait-io:main Jul 23, 2025
12 checks passed
@nielspardon nielspardon deleted the par-import-star branch August 5, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants