Template inclusion failed in checkbox.ftl when overriding the bootstrap theme

[stertooy]

Apologies in advance if this is due to my own limited understanding of this plugin, but here goes...

I'm using a custom theme (let's call it my-custom-theme) which sets the bootstrap theme, provided by this plugin, as its parent. This theme overrides some files, but in particular it does not override bootstrap/checkbox.ftl or bootstrap/simple/checkbox.ftl.

[...]
Caused by: freemarker.core._MiscTemplateException: Template inclusion failed (for parameter value "/template/~~~my-custom-theme/simple/checkbox.ftl"):
Template not found for name "template/~~~my-custom-theme/simple/checkbox.ftl".
The name was interpreted by this TemplateLoader: org.apache.struts2.views.freemarker.FreemarkerThemeTemplateLoader@546ebaed.

----
FTL stack trace ("~" means nesting-related):
	- Failed at: #include "/${attributes.templateDir}/...  [in template "template/bootstrap/checkbox.ftl" at line 50, column 10]
----
[...]
Caused by: freemarker.template.TemplateNotFoundException: Template not found for name "template/~~~my-custom-theme/simple/checkbox.ftl".
The name was interpreted by this TemplateLoader: org.apache.struts2.views.freemarker.FreemarkerThemeTemplateLoader@546ebaed.

The line mentioned in the error is

struts2-bootstrap/struts2-bootstrap-plugin/src/main/resources/template/bootstrap/checkbox.ftl

Line 50 in 80607da

<#include "/${attributes.templateDir}/${attributes.expandTheme}/simple/checkbox.ftl" />

I was under the impression that, since I don't provide a my-custom-theme/simple/checkbox.ftl file, the expandTheme parameter would ensure it tries to load bootstrap/simple/checkbox.ftl instead. But that does not seem to be the case?

[lukaszlenart]

Do you have theme.properties file defined with parent = bootstrap?
https://struts.apache.org/tag-developers/extending-themes#extending-an-existing-theme

[stertooy]

Yes, I do.

[lukaszlenart]

I was under the impression that, since I don't provide a my-custom-theme/simple/checkbox.ftl file, the expandTheme parameter would ensure it tries to load bootstrap/simple/checkbox.ftl instead. But that does not seem to be the case?

Yeah, it should work like that, yet having simple under the same them is somehow unusual. I would try to move bootstrap/simple/checkbox.ftl under simple/checkbox.ftl to override simple's checkbox.

[stertooy]

I'm not sure if I interpreted correctly what you meant, but making a file my-custom-theme/simple/checkbox.ftl with the exact same contents as bootstrap/simple/checkbox.ftl fixed the problem.

Alternatively, making a file my-custom-theme/simple/theme.properties with parent=bootstrap/simple also seems to resolve the issue.

[lukaszlenart]

Yeah, parent=bootstrap/simple should solve the problem, but this is hakish ... what I ment is to fix the plugin first, it shouldn't implement bootstrap/simple/checkbox.ftl but simple/checkbox.ftl