Proposal: Merging dev changes to main (DAO 98) #3709
Description
Hi Steemians!
The DAO-98 has finished. So… what’s next? Are we ready to merge these changes into the main branch?
Summary of Changes
The following PRs are included:
- Enable Basic Tests and Use 4 Theads to Build #3707 (CI Pipeline)
- Add Basic Github CI to Build All Dockerfiles #3706 (CI Pipeline)
- Fixes and Refactor the Docker files #3705 (Refactor/Fixes)
- Fix test_block_log #3704 (Fix test_block_log)
- Compile steemd on Debian 13 (Trinx) #3703 (Debian13)
- Make Steem Great Again: Support AzureLinux3! #3702 (AzureLinux3)
- Make steemd compiled at Ubuntu24.04 #3701 (Ubuntu24.04)
- Add Ubuntu 22.04 Support for steemd #3700 (Ubuntu22.04)
- Refactor and Cleanup: Ubuntu20.04 and Remove Ubuntu18.04 #3699 (Ubuntu20.04 - cleanup - submodule fixes etc)
Pre-built Docker Images
The following images are already available:
- docker pull justyy/steem:debian13
- docker pull justyy/steem:azurelinux3
- docker pull justyy/steem:ubuntu24.04
- docker pull justyy/steem:ubuntu22.04
- docker pull justyy/steem:ubuntu20.04
Before: steemd only builds at Ubuntu18.04
Now: It supports: ubuntu20.04, ubuntu22.04, ubuntu24.04, azurelinux3 and debian13.
All prebuilt steemd images can be found here:
👉 https://hub.docker.com/r/justyy/steem/tags
Tests Performed
I’ve been running steemd (built for Ubuntu 24.04) on my NUC-8, which has been running smoothly for ~80 days. The following tests were completed:
- Partial Sync from block 1 (≈ 2 days)
- Sync from snapshot, continue to latest block height, and generate blocks
- Stop/start steemd
- RPC calls
- Wallet CLI
The following plugins are tested.
plugin = witness block_api webserver condenser_api
Known Problem(s)
- Replay appears to be slower, but this is likely related to parameters or configuration rather than the build itself.
TLDR;
The changes do not modify any application logic. As you can see, they mainly consist of library (submodules) updates, and fixes for C++ language compatibility issues. As a result, these changes should be safe to merge and, in fact, improve overall security and maintainability.
With these changes in place, we finally have basic builds and tests running in the GitHub pipeline!
Vote to merge!
- If you agree that these changes should be merged, please reply with your witness ID and a statement such as “I approve” or “I vote to merge.”
- If you believe the changes are not yet ready, please share your concerns and explain what still needs to be done.
Let’s work toward moving this forward.