firefox on riscv platform

[kush930]

Hi all,

I want to port firefox on riscv64, using glibc-2.32 and gcc-10.2.0 and python3.8 version on target board.

I followed the below procedure:-

1. $ curl --proto '=https' --tlsv1.2 -sSf [https://sh.rustup.rs |](https://sh.rustup.rs%20%7C/) sh $ rustup default 1.63.0
2. $ git clone https://salsa.debian.org/mozilla-team/firefox.git -b debian/105.0-1 --depth=1

3. patch applied successfully:-
    $ patch -Np1 -i 0001-Bug-1786638-Return-early-if-we-can-t-fetch-an-intern.patch 
    $ patch -Np1 -i firefox-riscv64-hack.patch 
    $ patch -Np1 -i makotokato-riscv64-support-and-zenithal-backported.patch


4. Building firefox by running:- 
      $ ./mach vendor rust --ignore-modified
        
    During running   " ./mach vendor rust --ignore-modified" , i am facing issue-

error: no such subcommand: `vet`

	Did you mean `fmt`?
Error running mach:

    ['vendor', 'rust', '--ignore-modified']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file vendor| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

  File "/home/root/Debian/firefox/firefox/python/mozbuild/mozbuild/vendor/mach_commands.py", line 200, in vendor_rust
    ok = vendor_command.vendor(**kwargs)
  File "/home/root/Debian/firefox/firefox/python/mozbuild/mozbuild/vendor/vendor_rust.py", line 761, in vendor
    vet = json.loads(res.stdout)
  File "/usr/lib/python3.8/json/__init__.py", line 357, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.8/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.8/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None

Can anyone suggest me where i am doing mistake.

T&R
Kush

[nerdcorenet]

error: no such subcommand: vet

This appears to be caused by the patch firefox-riscv64-hack.patch which comments out the definition of vet:
https://github.com/starfive-tech/Debian/blob/20221225T084846Z/firefox/patch/firefox-riscv64-hack.patch#L32
is replaced by
https://github.com/starfive-tech/Debian/blob/20221225T084846Z/firefox/patch/firefox-riscv64-hack.patch#L66

So it seems you did nothing wrong @kush930 and followed the instructions correctly, but the patch supplied in this repository breaks the firefox build process.

It might be interesting and insightful to try:

• Not applying the "riscv-hack" patch, to see what happens
• Bring firefox source tree up to a more recent release; 105.0 is dated March 2023 https://ftp.mozilla.org/pub/firefox/releases/105.0/

[nerdcorenet]

Pinging @clefrks and @makotokato to see if either of them have insight into this.

This patch file:
https://github.com/starfive-tech/Debian/blob/20221225T084846Z/firefox/patch/firefox-riscv64-hack.patch
indicates that it is required in order to support this patch file (and BTW spells Makoto Kato's name incorrectly as 'matoko' :P ):
https://github.com/starfive-tech/Debian/blob/20221225T084846Z/firefox/patch/makotokato-riscv64-support-and-zenithal-backported.patch

I'm unsure what MK's patch is meant to accomplish here, or whether it would still be required today if we were to bring the FF sources from 105.0 to a more recent release for this platform.

[makotokato]

./mach vendor rust requires cargo-vet tool that you can install by cargo install cargo-vet.