go.mod: fix module path for v2 tags by nkryuchkov · Pull Request #2720 · ssvlabs/ssv

nkryuchkov · 2026-03-13T11:57:32Z

This fixes the Go module path so v2.x tags can actually be consumed as a library.

Currently, since our major release versions are v2.x, external go get fails for tags due to the module not being declared with the /v2 suffix

Closes ssvlabs/ssv-node-board#1060

codecov · 2026-03-13T12:00:24Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.3%. Comparing base (7622b38) to head (e9dfbeb).

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

iurii-ssv

Looks good if it works.

nkryuchkov · 2026-03-13T15:58:43Z

Looks good if it works.

% tmpdir="$(mktemp -d)"
cd "$tmpdir"
go mod init verifyrelease
GOPROXY=direct GOSUMDB=off go get github.com/ssvlabs/ssv/protocol/v2/types@v2.4.2

go: creating new go.mod: module verifyrelease
go: github.com/ssvlabs/ssv/protocol/v2/types@v2.4.2: github.com/ssvlabs/ssv@v2.4.2: invalid version: module contains a go.mod file, so module path must match major version ("github.com/ssvlabs/ssv/v2")
%

% tmpdir="$(mktemp -d)"
cd "$tmpdir"
go mod init verifyfix
GOPROXY=direct GOSUMDB=off go get github.com/ssvlabs/ssv/v2/protocol/v2/types@fix-go-v2-module

go build github.com/ssvlabs/ssv/v2/protocol/v2/types
go: creating new go.mod: module verifyfix
go: added github.com/attestantio/go-eth2-client v0.27.0
(...)
go: added gopkg.in/yaml.v2 v2.4.0
%

The proper testing would require creating a version, though

# Conflicts: # network/p2p/p2p_discovery.go # operator/duties/attester.go # operator/duties/scheduler.go # operator/duties/sync_committee.go # protocol/v2/queue/worker/message_worker.go

oleg-ssvlabs

I was quite boring person and went through all 400 files.
Left couple of comments. There is no need to add V2 to github URLs. I believe it will result in 404

nkryuchkov · 2026-03-25T13:56:17Z

I was quite boring person and went through all 400 files. Left couple of comments. There is no need to add V2 to github URLs. I believe it will result in 404

Thanks for the thorough review. Well spotted!

oleg-ssvlabs

lgtm!

momosh-ssv

Seems like a well played mechanical import path rename — no logic changes.

# Conflicts: # go.mod # go.sum

…-module # Conflicts: # api/handlers/node/node.go # api/handlers/node/node_test.go # cli/operator/node.go # cli/operator/prober.go # go.mod # network/p2p/p2p_discovery.go # network/p2p/p2p_discovery_test.go # nodeprobe/nodeprobe.go # nodeprobe/nodeprobe_test.go # ssvsigner/client.go # ssvsigner/cmd/purge-keys/purge-keys.go # ssvsigner/e2e/common/beacon_config.go # ssvsigner/e2e/testenv/environment.go # ssvsigner/e2e/testenv/key_managers.go # ssvsigner/ekm/key_manager.go # ssvsigner/ekm/local_key_manager.go # ssvsigner/ekm/local_key_manager_test.go # ssvsigner/ekm/mock.go # ssvsigner/ekm/remote_key_manager.go # ssvsigner/ekm/remote_key_manager_test.go # ssvsigner/ekm/signer_storage.go # ssvsigner/ekm/signer_storage_test.go # ssvsigner/ekm/slashing_protector.go # ssvsigner/ekm/slashing_protector_test.go # ssvsigner/go.mod # ssvsigner/observability.go # ssvsigner/server.go

…-module # Conflicts: # protocol/v2/qbft/config.go # protocol/v2/qbft/spectest/msg_processing_type.go # protocol/v2/qbft/spectest/qbft_mapping_test.go # protocol/v2/ssv/runner/committee_test.go # protocol/v2/ssv/runner/proposer_test.go # protocol/v2/ssv/runner/timer.go # protocol/v2/ssv/spectest/msg_processing_type.go # protocol/v2/ssv/spectest/multi_start_new_runner_duty_type.go # protocol/v2/testing/utils.go

ljuba-ssv

After merge, the two go test invocations in .github/workflows/dutytracer-bench.yml will fail — the file isn't in this PR's diff so I couldn't anchor inline, but the lines are:

L29: go test -benchmem -run=^$ -bench ^BenchmarkTracer$ github.com/ssvlabs/ssv/operator/dutytracer -v
L34: go test -tags lfs -timeout 5s -run ^TestEviction$ github.com/ssvlabs/ssv/operator/dutytracer -v

Both use the old github.com/ssvlabs/ssv/operator/dutytracer path. Once the module is renamed to github.com/ssvlabs/ssv/v2 this no longer resolves. Verified on this branch:

$ go test -list '.*' github.com/ssvlabs/ssv/operator/dutytracer
# github.com/ssvlabs/ssv/operator/dutytracer
no required module provides package github.com/ssvlabs/ssv/operator/dutytracer
FAIL    github.com/ssvlabs/ssv/operator/dutytracer [setup failed]
exit=1

github.com/ssvlabs/ssv/v2/operator/dutytracer resolves cleanly. The workflow will break on the next workflow_dispatch or push to feat/exporter-v2. Two-line fix: add /v2/ to both test paths.

# Conflicts: # go.mod # message/validation/consensus_validation.go # message/validation/consensus_validation_test.go # protocol/v2/qbft/controller/controller_test.go # protocol/v2/qbft/controller/decided.go # protocol/v2/qbft/instance/test_helpers_test.go # protocol/v2/qbft/spectest/controller_type.go # protocol/v2/qbft/spectest/msg_processing_type.go # protocol/v2/qbft/spectest/qbft_mapping_test.go # protocol/v2/ssv/runner/committee_test.go # protocol/v2/ssv/runner/timer.go # protocol/v2/ssv/spectest/msg_processing_type.go # protocol/v2/ssv/spectest/multi_start_new_runner_duty_type.go # protocol/v2/ssv/spectest/ssv_mapping_test.go # protocol/v2/ssv/validator/committee_queue_test.go # protocol/v2/ssv/validator/timer.go

These two files were added on stage with `github.com/ssvlabs/ssv/...` imports and slipped through the v2 path rewrite during the merge from stage. Update them to use the `github.com/ssvlabs/ssv/v2/...` paths the module declares.

Bumps go.opentelemetry.io/otel, otel/metric, and otel/trace from v1.38.0 to v1.41.0 to match the versions stage already pulls in transitively. Run via `go mod tidy`.

iurii-ssv

LGTM

momosh-ssv · 2026-05-11T08:55:04Z

Deferring to v2.4.4 so we can verify properly.

Per @nkryuchkov's test note: the branch-based go get …@fix-go-v2-module works, but Go only enforces the major-version-suffix rule on semver-tagged versions, so the fix can't be fully validated until a real tag is published. Since tags are immutable on proxy.golang.org, we don't want to discover a problem post-cut for v2.4.3.

Plan for v2.4.4:

Merge this PR after v2.4.3 ships.
Cut v2.4.4-rc1 (or similar) and verify go get github.com/ssvlabs/ssv/v2/...@v2.4.4-rc1 resolves cleanly.
Promote to v2.4.4 once green.

Tracking issue moved to milestone v2.4.4: ssvlabs/ssv-node-board#1060.

go.mod: fix module path for v2 tags

864e400

nkryuchkov requested review from a team as code owners March 13, 2026 11:57

nkryuchkov added 3 commits March 13, 2026 15:06

ssvsigner: use root v2 pseudo-version

b7e88ab

go.mod: use ssvsigner pseudo-version

73c2ea3

go.sum: add ssvsigner pseudo-version checksums

8cfeffa

nkryuchkov requested a review from iurii-ssv March 13, 2026 12:45

iurii-ssv reviewed Mar 13, 2026

View reviewed changes

iurii-ssv previously approved these changes Mar 13, 2026

View reviewed changes

Merge remote-tracking branch 'origin/stage' into fix-go-v2-module

3bb3a16

# Conflicts: # network/p2p/p2p_discovery.go # operator/duties/attester.go # operator/duties/scheduler.go # operator/duties/sync_committee.go # protocol/v2/queue/worker/message_worker.go

nkryuchkov dismissed iurii-ssv’s stale review via 3bb3a16 March 25, 2026 08:52

nkryuchkov requested a review from iurii-ssv March 25, 2026 08:52

fix test imports after stage merge

a69a068

iurii-ssv previously approved these changes Mar 25, 2026

View reviewed changes

oleg-ssvlabs requested changes Mar 25, 2026

View reviewed changes

nkryuchkov added 2 commits March 25, 2026 16:46

revert github url changes in comments

f67968f

fix remaining github comment url

de493ce

nkryuchkov dismissed iurii-ssv’s stale review via de493ce March 25, 2026 13:55

nkryuchkov requested review from iurii-ssv and oleg-ssvlabs March 25, 2026 13:56

oleg-ssvlabs previously approved these changes Mar 25, 2026

View reviewed changes

iurii-ssv previously approved these changes Mar 25, 2026

View reviewed changes

momosh-ssv previously approved these changes Mar 26, 2026

View reviewed changes

Merge remote-tracking branch 'origin/stage' into fix-go-v2-module

b73085a

# Conflicts: # go.mod # go.sum

nkryuchkov dismissed stale reviews from momosh-ssv, iurii-ssv, and oleg-ssvlabs via b73085a March 26, 2026 09:46

nkryuchkov dismissed stale reviews from ljuba-ssv and iurii-ssv via 516c66a April 14, 2026 17:49

nkryuchkov requested review from iurii-ssv and ljuba-ssv April 14, 2026 17:52

ljuba-ssv previously approved these changes Apr 15, 2026

View reviewed changes

oleg-ssvlabs previously approved these changes Apr 15, 2026

View reviewed changes

nkryuchkov dismissed stale reviews from oleg-ssvlabs and ljuba-ssv via 3a05870 April 17, 2026 18:09

nkryuchkov requested review from ljuba-ssv and oleg-ssvlabs April 17, 2026 18:09

iurii-ssv previously approved these changes Apr 20, 2026

View reviewed changes

oleg-ssvlabs previously approved these changes Apr 20, 2026

View reviewed changes

ljuba-ssv reviewed Apr 22, 2026

View reviewed changes

nkryuchkov added 2 commits April 23, 2026 20:13

fix pre-v2 leftovers

6e01126

Merge remote-tracking branch 'origin/stage' into fix-go-v2-module

39a294a

nkryuchkov dismissed stale reviews from oleg-ssvlabs and iurii-ssv via 39a294a April 23, 2026 17:40

nkryuchkov requested review from iurii-ssv, ljuba-ssv and oleg-ssvlabs April 23, 2026 17:40

oleg-ssvlabs previously approved these changes Apr 24, 2026

View reviewed changes

momosh-ssv added 3 commits May 8, 2026 17:10

fix: rewrite stale ssv imports in stage-added files

7319df8

These two files were added on stage with `github.com/ssvlabs/ssv/...` imports and slipped through the v2 path rewrite during the merge from stage. Update them to use the `github.com/ssvlabs/ssv/v2/...` paths the module declares.

go.mod: tidy after stage merge

e9dfbeb

Bumps go.opentelemetry.io/otel, otel/metric, and otel/trace from v1.38.0 to v1.41.0 to match the versions stage already pulls in transitively. Run via `go mod tidy`.

momosh-ssv dismissed oleg-ssvlabs’s stale review via e9dfbeb May 8, 2026 15:16

iurii-ssv approved these changes May 8, 2026

View reviewed changes

oleg-ssvlabs approved these changes May 11, 2026

View reviewed changes

Conversation

nkryuchkov commented Mar 13, 2026 • edited by momosh-ssv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

iurii-ssv left a comment

Choose a reason for hiding this comment

Uh oh!

nkryuchkov commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oleg-ssvlabs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nkryuchkov commented Mar 25, 2026

Uh oh!

oleg-ssvlabs left a comment

Choose a reason for hiding this comment

Uh oh!

momosh-ssv left a comment

Choose a reason for hiding this comment

Uh oh!

ljuba-ssv left a comment

Choose a reason for hiding this comment

Uh oh!

iurii-ssv left a comment

Choose a reason for hiding this comment

Uh oh!

momosh-ssv commented May 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nkryuchkov commented Mar 13, 2026 •

edited by momosh-ssv

Loading

codecov Bot commented Mar 13, 2026 •

edited

Loading

nkryuchkov commented Mar 13, 2026 •

edited

Loading