kernel32.CreateRemoteThread() may return None

[HMaker]

When the process exits while CreateRemoteThread is called, the return type is None, but pymem is not checking that below:

Pymem/pymem/__init__.py

Lines 168 to 183 in 0ca7f66

	params = params or 0
	NULL_SECURITY_ATTRIBUTES = ctypes.cast(0, pymem.ressources.structure.LPSECURITY_ATTRIBUTES)
	thread_h = pymem.ressources.kernel32.CreateRemoteThread(
	self.process_handle,
	NULL_SECURITY_ATTRIBUTES,
	0,
	address,
	params,
	0,
	ctypes.byref(ctypes.c_ulong(0))
	)
	last_error = ctypes.windll.kernel32.GetLastError()
	if last_error:
	pymem.logger.warning('Got an error in start thread, code: %s' % last_error)
	pymem.ressources.kernel32.WaitForSingleObject(thread_h, -1)
	pymem.logger.debug('New thread_id: 0x%08x' % thread_h)

GetLastError() returned code 5 and I got logging error TypeError: %x format: an integer is required, not NoneType at line 183.

[OpsecGuy]

I see an issue in your code at line 182.
thread_h returns 2 values. 1st one is PyHANDLE and second one is thread id so passing whole list into WaitForSingleObject is wrong as you should pass PyHANDLE only.

Print out your thread and check what values it stores. In my case:

new_thread = win32process.CreateRemoteThread(game.process_handle, None, 0, address, buffer, 0)
print(new_thread)
(PyHANDLE:1852, 6572)

[srounet]

Nice find, thank you for pointing this out @StarrFox do you confirm ?

[StarrFox]

seems correct to me, also think it would be nice to add the error message text from GetLastErrorAsString so it's easier to tell what the error code means