From b2b15066973376c7ef0c02f414f63e19f384d87b Mon Sep 17 00:00:00 2001 From: aniruth37 Date: Thu, 5 Feb 2026 00:02:38 +0530 Subject: [PATCH] fix: add creator comment field in Spdx2to3converter --- .../java/org/spdx/library/conversion/Spdx2to3Converter.java | 1 + .../org/spdx/library/conversion/Spdx2to3ConverterTest.java | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/main/java/org/spdx/library/conversion/Spdx2to3Converter.java b/src/main/java/org/spdx/library/conversion/Spdx2to3Converter.java index 52241283..0bb9a0ad 100644 --- a/src/main/java/org/spdx/library/conversion/Spdx2to3Converter.java +++ b/src/main/java/org/spdx/library/conversion/Spdx2to3Converter.java @@ -315,6 +315,7 @@ public static CreationInfo convertCreationInfo( CreationInfo retval = new CreationInfo.CreationInfoBuilder(modelStore, modelStore.getNextId(IdType.Anonymous), null) .setCreated(creationInfoV2.getCreated()) .setSpecVersion(SpdxConstantsV3.MODEL_SPEC_VERSION) + .setComment(creationInfoV2.getComment().orElse(null)) .build(); retval.setIdPrefix(uriPrefix); for (String docCreator:creationInfoV2.getCreators()) { diff --git a/src/test/java/org/spdx/library/conversion/Spdx2to3ConverterTest.java b/src/test/java/org/spdx/library/conversion/Spdx2to3ConverterTest.java index 310e075c..3675e0df 100644 --- a/src/test/java/org/spdx/library/conversion/Spdx2to3ConverterTest.java +++ b/src/test/java/org/spdx/library/conversion/Spdx2to3ConverterTest.java @@ -137,12 +137,14 @@ public void testConvertCreationInfo() throws InvalidSPDXAnalysisException { String organizationCreatorName = "Source Auditor Inc."; String organizationCreator = SpdxConstantsCompatV2.CREATOR_PREFIX_ORGANIZATION + organizationCreatorName; String created = "2010-01-29T18:30:22Z"; + String comment = "Test creation info comment"; String licenseListVersion = "3.21"; SpdxCreatorInformation creatorInfo = new SpdxCreatorInformation(fromModelStore, DOCUMENT_URI, creatorId, copyManager, true); creatorInfo.getCreators().add(personCreator); creatorInfo.getCreators().add(toolCreator); creatorInfo.getCreators().add(organizationCreator); creatorInfo.setCreated(created); + creatorInfo.setComment(comment); creatorInfo.setLicenseListVersion(licenseListVersion); List verify = creatorInfo.verify(); assertTrue(verify.isEmpty()); @@ -173,6 +175,7 @@ public void testConvertCreationInfo() throws InvalidSPDXAnalysisException { assertEquals(1, tools.length); assertEquals(toolCreatorName, tools[0].getName().get()); assertEquals(created, result.getCreated()); + assertEquals(comment, result.getComment().orElse(null)); assertEquals(IdType.Anonymous, toModelStore.getIdType(result.getObjectUri())); verify = result.verify(); assertTrue(verify.isEmpty());