Skip to content

fix: Fix response body corruption on retry by rewinding after truncate #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richardwang1124 merged 3 commits into from
May 26, 2026
+11 −0
Merged

fix: Fix response body corruption on retry by rewinding after truncate #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9f7ef3
Rewind after truncate
richardwang1124 May 26, 2026
06b3592
Add unit test
richardwang1124 May 26, 2026
f76cec7
Merge branch 'decaf' into fix/response-reset
richardwang1124 May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gems/smithy-client/lib/smithy-client/http/response.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ def reset
@status_code = 0
@headers.clear
@body.truncate(0)
@body.rewind
@error = nil
end

Expand Down
10 changes: 10 additions & 0 deletions gems/smithy-client/spec/smithy-client/http/response_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,16 @@ module Http
expect(response.status_code).to eq(0)
expect(response.error).to be_nil
end

it 'rewinds the body position so subsequent writes start at the beginning' do
subject.signal_data('first response body')
subject.signal_done
subject.body.read
subject.reset
subject.signal_data('second response body')
subject.signal_done
expect(subject.body.read).to eq('second response body')
end
end

describe '#signal_headers' do
Expand Down
Loading