From d99af4bae5fabfdc1818c707661db6ba0c8ecc2a Mon Sep 17 00:00:00 2001 From: Henry Thornley Date: Fri, 25 Aug 2023 07:57:36 -0700 Subject: [PATCH 1/6] CircleCI to Actions - Add PR Actions file --- .github/workflows/pull-request.yml | 50 ++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 .github/workflows/pull-request.yml diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml new file mode 100644 index 00000000..24e4edd6 --- /dev/null +++ b/.github/workflows/pull-request.yml @@ -0,0 +1,50 @@ +name: Lint, Test, and Danger + +on: pull_request + +# https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token +permissions: + checks: write + contents: write + pull-requests: write + statuses: write + +jobs: + lint-test-danger: + runs-on: ubuntu-latest + steps: + - name: Checkout repo + uses: actions/checkout@v3 + + - name: Setup node + uses: actions/setup-node@v3 + with: + node-version: 16 + cache: 'yarn' + + - name: Install dependencies + run: yarn install --immutable + + - name: Lint + uses: wearerequired/lint-action@v2 + with: + auto_fix: true + eslint: true + eslint_command_prefix: yarn + prettier: true + prettier_command_prefix: yarn + + - name: Test + run: yarn cicoverage + env: + NODE_OPTIONS: '--no-warnings --experimental-vm-modules' + + - name: Report Coverage + uses: romeovs/lcov-reporter-action@2a28ec3e25fb7eae9cb537e9141603486f810d1a + with: + delete-old-comments: true + + - name: Run danger + run: yarn run danger ci -d dangerfile.cjs + env: + DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} From c52bb6a687e05356cca2009fd0e6e590f74d65b9 Mon Sep 17 00:00:00 2001 From: Henry Thornley Date: Fri, 25 Aug 2023 08:17:34 -0700 Subject: [PATCH 2/6] Update --- .github/workflows/pull-request.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 24e4edd6..01f54f87 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -39,10 +39,10 @@ jobs: env: NODE_OPTIONS: '--no-warnings --experimental-vm-modules' - - name: Report Coverage - uses: romeovs/lcov-reporter-action@2a28ec3e25fb7eae9cb537e9141603486f810d1a + - uses: tintef/nyc-reporter-action with: - delete-old-comments: true + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + REPORTER: 'text' # defaults to 'text-summary' - name: Run danger run: yarn run danger ci -d dangerfile.cjs From dbd26a4883946ea4ff54c247d1d8df76c6c8c1ff Mon Sep 17 00:00:00 2001 From: Henry Thornley Date: Fri, 25 Aug 2023 08:29:15 -0700 Subject: [PATCH 3/6] Coverage --- .github/workflows/pull-request.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 01f54f87..c9df0d54 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -39,7 +39,8 @@ jobs: env: NODE_OPTIONS: '--no-warnings --experimental-vm-modules' - - uses: tintef/nyc-reporter-action + - name: NYC Coverage Report + uses: Tintef/nyc-reporter-action@0.1.0 with: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} REPORTER: 'text' # defaults to 'text-summary' From 5ac0a77211a68f96c75ed733d2610401f3daeee8 Mon Sep 17 00:00:00 2001 From: Henry Thornley Date: Fri, 25 Aug 2023 08:32:59 -0700 Subject: [PATCH 4/6] Update --- .github/workflows/pull-request.yml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index c9df0d54..ead80457 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -26,13 +26,7 @@ jobs: run: yarn install --immutable - name: Lint - uses: wearerequired/lint-action@v2 - with: - auto_fix: true - eslint: true - eslint_command_prefix: yarn - prettier: true - prettier_command_prefix: yarn + run: yarn ci:lint - name: Test run: yarn cicoverage From 4fec6ed86ff188851224d192a7beae3273832be9 Mon Sep 17 00:00:00 2001 From: Henry Thornley Date: Fri, 25 Aug 2023 08:34:25 -0700 Subject: [PATCH 5/6] Update --- .github/workflows/pull-request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index ead80457..29a4c0cf 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -26,7 +26,7 @@ jobs: run: yarn install --immutable - name: Lint - run: yarn ci:lint + run: yarn lint:ci - name: Test run: yarn cicoverage From 21bfecf35cc718f7edfd5eec9e7963bd53b6ba2e Mon Sep 17 00:00:00 2001 From: Henry Thornley Date: Fri, 25 Aug 2023 09:47:52 -0700 Subject: [PATCH 6/6] Update --- dangerfile.cjs | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 dangerfile.cjs diff --git a/dangerfile.cjs b/dangerfile.cjs new file mode 100644 index 00000000..a1a0b145 --- /dev/null +++ b/dangerfile.cjs @@ -0,0 +1,21 @@ +let { danger, markdown, fail, message, warn } = require('danger') +let duti = require('duti') + +let args = { + danger, + fail, + message, + warn, + markdown, + config: { + prNetChangeThreshold: 500, + personalityNetChangeThreshold: 500, + recommendedPrReviewers: 1, + }, +} + +duti.prAssignee(args) +duti.netNegativePR(args) +duti.bigPr(args) +duti.noPrDescription(args) +duti.requestedReviewers(args)