Scene Reset On File Open

[tonybarbieri]

Hello!

Is there a reason why scene reset is being called before opening a file? We are getting some bad crashes with tk-softimage due to onNewScene events firing in that scene reset stage and then the file immediately opening...might be some sort of race condition? Just curious if the scene reset is necessary or if it can be removed.

Thanks!

-tony

[alandann]

Hi Tony,

The scene reset is intended to prepare the scene for a file to be loaded in to it. The intention was that any 'do you want to save unsaved changes' and the like would happen in there so that when a file is opened it can just happen.

We're aware of the Softimage issue though - it's something to do with the confirmation dialog of the OpenScene command being suppressed in the 'open' action but I've not had time to delve into this yet. Apparently, changing the line from Application.OpenScene(file_path, 0, 0) to Application.OpenScene(file_path, 1, 0) will stop the crashing although you'll get the confirmation dialog multiple times!

I'd be interested to know if this stops your crashes as well?

Alan

[tonybarbieri]

I'll test it out!!

Thanks Alan!

-tony

On Tue, Jul 9, 2013 at 7:00 PM, alandann notifications@github.com wrote:

Hi Tony,

The scene reset is intended to prepare the scene for a file to be loaded
in to it. The intention was that any 'do you want to save unsaved changes'
and the like would happen in there so that when a file is opened it can
just happen.

We're aware of the Softimage issue though - it's something to do with the
confirmation dialog of the OpenScene command being suppressed in the 'open'
action but I've not had time to delve into this yet. Apparently, changing
the line from Application.OpenScene(file_path, 0, 0) to
Application.OpenScene(file_path, 1, 0) will stop the crashing although
you'll get the confirmation dialog multiple times!

I'd be interested to know if this stops your crashes as well?

Alan

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/13#issuecomment-20711531
.

-tony

[tonybarbieri]

Hey Alan,

So this works...kind of. It doesn't crash, but the second save dialog does indeed pop up asking to save the "intermediate" new scene (which a user will never want to do and seems confusing)...going to try to figure out another way to solve this. It's too bad that suppressing the Save Dialog is causing a crash.....

Is it necessary to do an actual scene reset (create a new scene) in order to have the "Do you want to save" dialog? In pull request #11, I have Tank asking the user to save and attempting to use the Tank Save As or Snapshot to do this. https://github.com/shotgunsoftware/tk-multi-workfiles/pull/11/files#L5L281. Perhaps this can be changed to a separate method, confirm_save or some such that can be used by both open_file and reset_scene...

If another DCC application requires that a new scene be created before an open, can this be put into the hook itself in the open_file secton?

Thanks!

-tony

[tonybarbieri]

Also as a note, this issue is coming from having Arnold as the default renderer in Softimage. SitoA (Softimage to Arnold) has an onNewScene event so this could be a pretty common issue and is hard to track down.

-tony

[alandann]

Hey Tony,

Just to let you know that the Softimage stuff has been released - although I'm pretty sure you saw that ;)

I found another workaround to the Arnold problem - calling Application.Desktop.RedrawUI() before doing the open seems to force all the OnEndNewScene events to finish correctly!

This is good as I also had to add the scene reset to the snapshot app (when doing a restore)!

Let me know what you think when you have time to check out the engine and thanks so much for all the work you guys put in - it saved me a massive amount of pain!

Alan