From e3832157521039620ffebc4f9ed3f2c48788f984 Mon Sep 17 00:00:00 2001 From: Eric Seidel Date: Mon, 23 Feb 2026 15:15:25 -0800 Subject: [PATCH] fix: Update iOS dSYM filename in artifact manifest The manifest template still referenced Flutter.dSYM.zip but mac_upload.sh uploads Flutter.framework.dSYM.zip (the new name as of Flutter 3.27.0). Update the template, generate script, and test to match what's actually uploaded. Relates to https://github.com/shorebirdtech/shorebird/issues/3035 --- shorebird/ci/artifacts_manifest.template.yaml | 2 +- shorebird/ci/internal/generate_manifest.sh | 2 +- shorebird/ci/shard_runner/test/manifest_test.dart | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/shorebird/ci/artifacts_manifest.template.yaml b/shorebird/ci/artifacts_manifest.template.yaml index 4b5c8a7f0809d..33223fced2de8 100644 --- a/shorebird/ci/artifacts_manifest.template.yaml +++ b/shorebird/ci/artifacts_manifest.template.yaml @@ -49,7 +49,7 @@ artifact_overrides: # iOS release artifacts - flutter_infra_release/flutter/$engine/ios-release/artifacts.zip - - flutter_infra_release/flutter/$engine/ios-release/Flutter.dSYM.zip + - flutter_infra_release/flutter/$engine/ios-release/Flutter.framework.dSYM.zip # Linux release artifacts - flutter_infra_release/flutter/$engine/linux-x64/artifacts.zip diff --git a/shorebird/ci/internal/generate_manifest.sh b/shorebird/ci/internal/generate_manifest.sh index 4c95de6baf098..ee9ef7ddfdf67 100755 --- a/shorebird/ci/internal/generate_manifest.sh +++ b/shorebird/ci/internal/generate_manifest.sh @@ -76,7 +76,7 @@ artifact_overrides: # iOS release artifacts # Includes unified Flutter.framework for device and simulator (debug) - flutter_infra_release/flutter/\$engine/ios-release/artifacts.zip - - flutter_infra_release/flutter/\$engine/ios-release/Flutter.dSYM.zip + - flutter_infra_release/flutter/\$engine/ios-release/Flutter.framework.dSYM.zip # Linux release artifacts - flutter_infra_release/flutter/\$engine/linux-x64/artifacts.zip diff --git a/shorebird/ci/shard_runner/test/manifest_test.dart b/shorebird/ci/shard_runner/test/manifest_test.dart index 1e8e930eb2458..a5606ae9b2f54 100644 --- a/shorebird/ci/shard_runner/test/manifest_test.dart +++ b/shorebird/ci/shard_runner/test/manifest_test.dart @@ -123,7 +123,7 @@ void main() { expect( manifest, contains( - r'flutter_infra_release/flutter/$engine/ios-release/Flutter.dSYM.zip')); + r'flutter_infra_release/flutter/$engine/ios-release/Flutter.framework.dSYM.zip')); }); test('includes Linux release artifacts', () {