From f7e47906751d340ad5a6331dc6169c00b378c572 Mon Sep 17 00:00:00 2001 From: Jim lesperance Date: Mon, 27 Nov 2023 15:53:42 +0100 Subject: [PATCH 1/2] Update Circleci config.yml We remove the required `check-code-quality` key to allow other steps to build properly Remove .rubocop.yml --- .circleci/config.yml | 60 ++-- .rubocop.yml | 765 ------------------------------------------- 2 files changed, 24 insertions(+), 801 deletions(-) delete mode 100644 .rubocop.yml diff --git a/.circleci/config.yml b/.circleci/config.yml index be35e63..deee5ff 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -2,57 +2,47 @@ version: 2.1 jobs: standard: docker: - - image: cimg/ruby:3.2.2 - environment: - LANG: en_US.UTF-8 + - environment: BUNDLE_DISABLE_VERSION_CHECK: 1 + LANG: en_US.UTF-8 + image: cimg/ruby:3.2.2 steps: - checkout - run: - name: Install ruby dependencies command: gem update --system; bin/setup + name: Install ruby dependencies - run: - name: Run standardrb command: bundle exec standardrb + name: Run standardrb build: parameters: image-tag: description: The target docker image type: string - check-code-quality: - description: Execute style checks in build workflow - type: boolean - default: true docker: - - image: cimg/<< parameters.image-tag >> - environment: - LANG: en_US.UTF-8 + - environment: BUNDLE_DISABLE_VERSION_CHECK: 1 + LANG: en_US.UTF-8 + image: cimg/<< parameters.image-tag >> steps: - checkout - run: - name: Install ruby dependencies command: gem update --system; bin/setup - - when: - condition: << parameters.check-code-quality >> - steps: - - run: - name: Install Code Climate test-reporter - command: | - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter - chmod +x ./cc-test-reporter - - run: - name: Prepare Code Climate test-reporter - command: ./cc-test-reporter before-build + name: Install ruby dependencies + - run: + command: | + curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter + chmod +x ./cc-test-reporter + name: Install Code Climate test-reporter + - run: + command: ./cc-test-reporter before-build + name: Prepare Code Climate test-reporter - run: - name: Execute specs command: bundle exec rake - - when: - condition: << parameters.check-code-quality >> - steps: - - run: - name: Report coverage - command: ./cc-test-reporter after-build --exit-code $? + name: Execute specs + - run: + command: ./cc-test-reporter after-build --exit-code $? + name: Report coverage workflows: build: @@ -69,8 +59,6 @@ workflows: matrix: parameters: image-tag: - - "ruby:3.0" - - "ruby:3.1" - - "ruby:3.2" - check-code-quality: - - false + - ruby:3.0 + - ruby:3.1 + - ruby:3.2 diff --git a/.rubocop.yml b/.rubocop.yml deleted file mode 100644 index b9444da..0000000 --- a/.rubocop.yml +++ /dev/null @@ -1,765 +0,0 @@ -require: - - rubocop-performance - - rubocop-rake - - rubocop-rspec - -AllCops: - TargetRubyVersion: 2.6 - NewCops: enable - Exclude: - - vendor/**/* - - db/schema.rb - - bin/* - - config/application.rb - - config/boot.rb - - config/environment.rb - -# rubocop -# https://github.com/rubocop-hq/rubocop/blob/master/config/default.yml - -# Layout - https://docs.rubocop.org/rubocop/cops_layout.html - -Layout/ConditionPosition: - Description: >- - Checks for condition placed in a confusing position relative to - the keyword. - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#same-line-condition' - Enabled: false - -Layout/DotPosition: - Description: 'Checks the position of the dot in multi-line method calls.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#consistent-multi-line-chains' - EnforcedStyle: trailing - -Layout/EmptyLineAfterMagicComment: - Description: 'Add an empty line after magic comments to separate them from code.' - StyleGuide: '#separate-magic-comments-from-code' - Enabled: false - -Layout/EmptyLinesAroundAttributeAccessor: - Description: "Keep blank lines around attribute accessors." - Enabled: true - -Layout/ExtraSpacing: - Description: 'Do not use unnecessary spacing.' - Enabled: true - -Layout/FirstArrayElementLineBreak: - Description: >- - Checks for a line break before the first element in a - multi-line array. - Enabled: true - -Layout/FirstHashElementLineBreak: - Description: >- - Checks for a line break before the first element in a - multi-line hash. - Enabled: true - -Layout/FirstMethodArgumentLineBreak: - Description: >- - Checks for a line break before the first argument in a - multi-line method call. - Enabled: true - -Layout/InitialIndentation: - Description: >- - Checks the indentation of the first non-blank non-comment line in a file. - Enabled: false - -Layout/LineLength: - Description: "Limit lines to 100 characters." - Max: 100 - Enabled: true - -Layout/MultilineMethodCallIndentation: - Description: >- - Checks indentation of method calls with the dot operator - that span more than one line. - Enabled: true - EnforcedStyle: indented - -Layout/MultilineOperationIndentation: - Description: >- - Checks indentation of binary operations that span more than - one line. - Enabled: true - EnforcedStyle: indented - -# Layout - https://docs.rubocop.org/rubocop/cops_lint.html - -Lint/AmbiguousOperator: - Description: >- - Checks for ambiguous operators in the first argument of a - method invocation without parentheses. - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#parens-as-args' - Enabled: false - -Lint/AmbiguousRegexpLiteral: - Description: >- - Checks for ambiguous regexp literals in the first argument of - a method invocation without parenthesis. - Enabled: false - -Lint/AssignmentInCondition: - Description: "Don't use assignment in conditions." - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#safe-assignment-in-condition' - Enabled: false - -Lint/DeprecatedClassMethods: - Description: 'Check for deprecated class method calls.' - Enabled: false - -Lint/DuplicateHashKey: - Description: 'Check for duplicate keys in hash literals.' - Enabled: false - -Lint/EachWithObjectArgument: - Description: 'Check for immutable argument given to each_with_object.' - Enabled: false - -Lint/ElseLayout: - Description: 'Check for odd code arrangement in an else block.' - Enabled: false - -Lint/FlipFlop: - Description: 'Checks for flip flops' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-flip-flops' - Enabled: false - -Lint/FormatParameterMismatch: - Description: 'The number of parameters to format/sprint must match the fields.' - Enabled: false - -Lint/LiteralAsCondition: - Description: 'Checks of literals used in conditions.' - Enabled: false - -Lint/LiteralInInterpolation: - Description: 'Checks for literals used in interpolation.' - Enabled: false - -Lint/Loop: - Description: >- - Use Kernel#loop with break rather than begin/end/until or - begin/end/while for post-loop tests. - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#loop-with-break' - Enabled: false - -Lint/NestedMethodDefinition: - Description: 'Do not use nested method definitions.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-nested-methods' - Enabled: false - -Lint/NonDeterministicRequireOrder: - Description: 'Always sort arrays returned by Dir.glob when requiring files.' - Enabled: true - -Lint/NonLocalExitFromIterator: - Description: 'Do not use return in iterator to cause non-local exit.' - Enabled: false - -Lint/ParenthesesAsGroupedExpression: - Description: >- - Checks for method calls with a space before the opening - parenthesis. - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#parens-no-spaces' - Enabled: false - -Lint/RaiseException: - Description: Checks for `raise` or `fail` statements which are raising `Exception` class. - Enabled: true - -Lint/RedundantCopDisableDirective: - Description: >- - Checks for rubocop:disable comments that can be removed. - Note: this cop is not disabled when disabling all cops. - It must be explicitly disabled. - Enabled: false - -Lint/RequireParentheses: - Description: >- - Use parentheses in the method call to avoid confusion - about precedence. - Enabled: false - -Lint/SuppressedException: - Description: "Don't suppress exception." - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#dont-hide-exceptions' - Enabled: false - -Lint/UnderscorePrefixedVariableName: - Description: 'Do not use prefix `_` for a variable that is used.' - Enabled: false - -Lint/Void: - Description: 'Possible use of operator/literal/variable in void context.' - Enabled: false - -# Metrics - https://docs.rubocop.org/rubocop/cops_metrics.html - -Metrics/AbcSize: - Description: >- - A calculated magnitude based on number of assignments, - branches, and conditions. - Enabled: false - -Metrics/BlockLength: - Description: 'Avoid long blocks with many lines.' - Enabled: true - IgnoredMethods: [task, namespace, describe, context, factory, it] - Exclude: - - !ruby/regexp /config/routes.rb$/ - -Metrics/BlockNesting: - Description: 'Avoid excessive block nesting' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#three-is-the-number-thou-shalt-count' - Enabled: false - -Metrics/ClassLength: - Description: 'Avoid classes longer than 100 lines of code.' - Enabled: false - -Metrics/CyclomaticComplexity: - Description: >- - A complexity metric that is strongly correlated to the number - of test cases needed to validate a method. - Enabled: false - -Metrics/MethodLength: - Description: 'Avoid methods longer than 10 lines of code.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#short-methods' - Enabled: false - -Metrics/ModuleLength: - Description: 'Avoid modules longer than 100 lines of code.' - Enabled: false - -Metrics/ParameterLists: - Description: 'Avoid parameter lists longer than three or four parameters.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#too-many-params' - Enabled: false - -# Naming - https://docs.rubocop.org/rubocop/cops_naming.html - -Naming/AccessorMethodName: - Description: Check the naming of accessor methods for get_/set_. - Enabled: false - -Naming/AsciiIdentifiers: - Description: 'Use only ascii symbols in identifiers.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#english-identifiers' - Enabled: false - -Naming/BinaryOperatorParameterName: - Description: 'When defining binary operators, name the argument other.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#other-arg' - Enabled: false - -Naming/FileName: - Description: 'Use snake_case for source file names.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#snake-case-files' - Enabled: false - -Naming/MemoizedInstanceVariableName: - Description: Memoized method name should match memo instance variable name. - Enabled: true - EnforcedStyleForLeadingUnderscores: required - -Naming/PredicateName: - Description: 'Check the names of predicate methods.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#bool-methods-qmark' - NamePrefix: - - is_ - - has_ - - have_ - ForbiddenPrefixes: - - is_ - Exclude: - - !ruby/regexp /spec(\/.*)*\/.*\.rb$/ - -Naming/RescuedExceptionsVariableName: - Description: 'Use consistent rescued exceptions variables naming.' - Enabled: true - PreferredName: error - -# Style - https://docs.rubocop.org/rubocop/cops_style.html - -Style/AccessorGrouping: - Description: 'Checks for grouping of accessors in `class` and `module` bodies.' - Enabled: true - -Style/Alias: - Description: 'Use alias_method instead of alias.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#alias-method' - Enabled: false - -Style/ArrayCoercion: - Description: >- - Use Array() instead of explicit Array check or [*var], when dealing - with a variable you want to treat as an Array, but you're not certain it's an array. - Enabled: true - -Style/ArrayJoin: - Description: 'Use Array#join instead of Array#*.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#array-join' - Enabled: false - -Style/AsciiComments: - Description: 'Use only ascii symbols in comments.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#english-comments' - Enabled: false - -Style/Attr: - Description: 'Checks for uses of Module#attr.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#attr' - Enabled: false - -Style/CaseEquality: - Description: 'Avoid explicit use of the case equality operator(===).' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-case-equality' - Enabled: false - -Style/CaseLikeIf: - Description: 'This cop identifies places where `if-elsif` constructions can be replaced with `case-when`.' - Enabled: true - -Style/CharacterLiteral: - Description: 'Checks for uses of character literals.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-character-literals' - Enabled: false - -Style/ClassAndModuleChildren: - Description: 'Checks style of children classes and modules.' - Enabled: true - EnforcedStyle: nested - -Style/ClassVars: - Description: 'Avoid the use of class variables.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-class-vars' - Enabled: false - -Style/CollectionMethods: - Enabled: true - PreferredMethods: - find: detect - reduce: inject - collect: map - collect!: map! - find_all: select - -Style/ColonMethodCall: - Description: 'Do not use :: for method call.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#double-colons' - Enabled: false - -Style/CommentAnnotation: - Description: >- - Checks formatting of special comments - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#annotate-keywords' - Enabled: false - -Style/Documentation: - Description: 'Document classes and non-namespace modules.' - Enabled: false - -Style/DoubleNegation: - Description: 'Checks for uses of double negation (!!).' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-bang-bang' - Enabled: false - -Style/EachWithObject: - Description: 'Prefer `each_with_object` over `inject` or `reduce`.' - Enabled: false - -Style/EmptyLiteral: - Description: 'Prefer literals to Array.new/Hash.new/String.new.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#literal-array-hash' - Enabled: false - -# Checks whether the source file has a utf-8 encoding comment or not -# AutoCorrectEncodingComment must match the regex -# /#.*coding\s?[:=]\s?(?:UTF|utf)-8/ -Style/Encoding: - Enabled: false - -Style/EvenOdd: - Description: 'Favor the use of Fixnum#even? && Fixnum#odd?' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#predicate-methods' - Enabled: false - -Style/FormatString: - Description: 'Enforce the use of Kernel#sprintf, Kernel#format or String#%.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#sprintf' - Enabled: false - -Style/GlobalVars: - Description: 'Do not introduce global variables.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#instance-vars' - Reference: 'http://www.zenspider.com/Languages/Ruby/QuickRef.html' - Enabled: false - -Style/GuardClause: - Description: 'Check for conditionals that can be replaced with guard clauses' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-nested-conditionals' - Enabled: false - -Style/HashAsLastArrayItem: - Description: >- - Checks for presence or absence of braces around hash literal as a last - array item depending on configuration. - Enabled: true - -Style/HashEachMethods: - Description: 'Use Hash#each_key and Hash#each_value.' - Enabled: false - -Style/HashLikeCase: - Description: >- - Checks for places where `case-when` represents a simple 1:1 - mapping and can be replaced with a hash lookup. - Enabled: true - -Style/HashTransformKeys: - Description: 'Prefer `transform_keys` over `each_with_object` and `map`.' - Enabled: false - -Style/HashTransformValues: - Description: 'Prefer `transform_values` over `each_with_object` and `map`.' - Enabled: false - -Style/IfUnlessModifier: - Description: >- - Favor modifier if/unless usage when you have a - single-line body. - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#if-as-a-modifier' - Enabled: false - -Style/IfWithSemicolon: - Description: 'Do not use if x; .... Use the ternary operator instead.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-semicolon-ifs' - Enabled: false - -Style/IpAddresses: - Description: "Don't include literal IP addresses in code." - Enabled: true - Exclude: - - !ruby/regexp /spec(\/.*)*\/.*\.rb$/ - -Style/Lambda: - Description: 'Use the new lambda literal syntax for single-line blocks.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#lambda-multi-line' - Enabled: false - -Style/LambdaCall: - Description: 'Use lambda.call(...) instead of lambda.(...).' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#proc-call' - Enabled: false - -Style/LineEndConcatenation: - Description: >- - Use \ instead of + or << to concatenate two string literals at - line end. - Enabled: false - -Style/ModuleFunction: - Description: 'Checks for usage of `extend self` in modules.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#module-function' - Enabled: false - -Style/MultilineBlockChain: - Description: 'Avoid multi-line chains of blocks.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#single-line-blocks' - Enabled: false - -Style/NegatedIf: - Description: >- - Favor unless over if for negative conditions - (or control flow or). - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#unless-for-negatives' - Enabled: false - -Style/NegatedWhile: - Description: 'Favor until over while for negative conditions.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#until-for-negatives' - Enabled: false - -Style/Next: - Description: 'Use `next` to skip iteration instead of a condition at the end.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-nested-conditionals' - Enabled: false - -Style/NilComparison: - Description: 'Prefer x.nil? to x == nil.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#predicate-methods' - Enabled: false - -Style/Not: - Description: 'Use ! instead of not.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#bang-not-not' - Enabled: false - -Style/NumericLiterals: - Description: >- - Add underscores to large numeric literals to improve their - readability. - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#underscores-in-numerics' - Enabled: false - -Style/OneLineConditional: - Description: >- - Favor the ternary operator(?:) over - if/then/else/end constructs. - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#ternary-operator' - Enabled: false - -Style/PercentLiteralDelimiters: - Description: 'Use `%`-literal delimiters consistently' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#percent-literal-braces' - Enabled: false - -Style/PerlBackrefs: - Description: 'Avoid Perl-style regex back references.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-perl-regexp-last-matchers' - Enabled: false - -Style/PreferredHashMethods: - Description: 'Checks use of `has_key?` and `has_value?` Hash methods.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#hash-key' - Enabled: false - -Style/Proc: - Description: 'Use proc instead of Proc.new.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#proc' - Enabled: false - -Style/RaiseArgs: - Description: 'Checks the arguments passed to raise/fail.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#exception-class-messages' - Enabled: false - -Style/RedundantFetchBlock: - Description: >- - Use `fetch(key, value)` instead of `fetch(key) { value }` - when value has Numeric, Rational, Complex, Symbol or String type, `false`, `true`, `nil` or is a constant. - Enabled: true - -Style/RegexpLiteral: - Description: 'Use / or %r around regular expressions.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#percent-r' - Enabled: false - -Style/Sample: - Description: >- - Use `sample` instead of `shuffle.first`, - `shuffle.last`, and `shuffle[Fixnum]`. - Reference: 'https://github.com/JuanitoFatas/fast-ruby#arrayshufflefirst-vs-arraysample-code' - Enabled: false - -Style/SelfAssignment: - Description: >- - Checks for places where self-assignment shorthand should have - been used. - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#self-assignment' - Enabled: false - -Style/SignalException: - Description: 'Checks for proper usage of fail and raise.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#fail-method' - Enabled: false - -Style/SingleLineBlockParams: - Description: 'Enforces the names of some block params.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#reduce-blocks' - Enabled: false - -Style/SingleLineMethods: - Description: 'Avoid single-line methods.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-single-line-methods' - Enabled: false - -Style/SlicingWithRange: - Description: 'Checks array slicing is done with endless ranges when suitable.' - Enabled: true - -Style/SpecialGlobalVars: - Description: 'Avoid Perl-style global variables.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-cryptic-perlisms' - Enabled: false - -Style/StringLiterals: - Description: 'Checks if uses of quotes match the configured preference.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#consistent-string-literals' - EnforcedStyle: double_quotes - Enabled: true - -Style/SymbolArray: - Enabled: false - -Style/TrailingCommaInArguments: - Description: 'Checks for trailing comma in argument lists.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas' - EnforcedStyleForMultiline: comma - SupportedStylesForMultiline: - - comma - - consistent_comma - - no_comma - Enabled: true - -Style/TrailingCommaInArrayLiteral: - Description: 'Checks for trailing comma in array literals.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas' - EnforcedStyleForMultiline: comma - SupportedStylesForMultiline: - - comma - - consistent_comma - - no_comma - Enabled: true - -Style/TrailingCommaInHashLiteral: - Description: 'Checks for trailing comma in hash literals.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas' - EnforcedStyleForMultiline: comma - SupportedStylesForMultiline: - - comma - - consistent_comma - - no_comma - Enabled: true - -Style/TrivialAccessors: - Description: 'Prefer attr_* methods to trivial readers/writers.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#attr_family' - Enabled: false - -Style/VariableInterpolation: - Description: >- - Don\'t interpolate global, instance and class variables - directly in strings. - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#curlies-interpolate' - Enabled: false - -Style/WhenThen: - Description: 'Use when x then ... for one-line cases.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#one-line-cases' - Enabled: false - -Style/WhileUntilModifier: - Description: >- - Favor modifier while/until usage when you have a - single-line body. - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#while-as-a-modifier' - Enabled: false - -Style/WordArray: - Description: 'Use %w or %W for arrays of words.' - StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#percent-w' - Enabled: false - -# rubocop-performance -# https://github.com/rubocop-hq/rubocop-performance/blob/master/config/default.yml - -# Performance - https://docs.rubocop.org/rubocop-performance/cops_performance.html - -Performance/Count: - Description: >- - Use `count` instead of `select...size`, `reject...size`, - `select...count`, `reject...count`, `select...length`, - and `reject...length`. - Enabled: false - -Performance/Detect: - Description: >- - Use `detect` instead of `select.first`, `find_all.first`, - `select.last`, and `find_all.last`. - Reference: 'https://github.com/JuanitoFatas/fast-ruby#enumerabledetect-vs-enumerableselectfirst-code' - Enabled: false - -Performance/FlatMap: - Description: >- - Use `Enumerable#flat_map` - instead of `Enumerable#map...Array#flatten(1)` - or `Enumberable#collect..Array#flatten(1)` - Reference: 'https://github.com/JuanitoFatas/fast-ruby#enumerablemaparrayflatten-vs-enumerableflat_map-code' - Enabled: false - -Performance/ReverseEach: - Description: 'Use `reverse_each` instead of `reverse.each`.' - Reference: 'https://github.com/JuanitoFatas/fast-ruby#enumerablereverseeach-vs-enumerablereverse_each-code' - Enabled: false - -Performance/Size: - Description: >- - Use `size` instead of `count` for counting - the number of elements in `Array` and `Hash`. - Reference: 'https://github.com/JuanitoFatas/fast-ruby#arraycount-vs-arraysize-code' - Enabled: false - -Performance/StringReplacement: - Description: >- - Use `tr` instead of `gsub` when you are replacing the same - number of characters. Use `delete` instead of `gsub` when - you are deleting characters. - Reference: 'https://github.com/JuanitoFatas/fast-ruby#stringgsub-vs-stringtr-code' - Enabled: false - -Performance/UnfreezeString: - Description: 'Use unary plus to get an unfrozen string literal.' - Enabled: false - -# rubocop-rspec - -RSpec/ContextWording: - Description: Checks that `context` docstring starts with an allowed prefix. - Enabled: false - -RSpec/DescribeClass: - Enabled: true - Description: Check that the first argument to the top level describe is a constant. - Exclude: - - !ruby/regexp /spec\/config(\/.*)*\/.*\.rb$/ - - !ruby/regexp /spec\/features(\/.*)*\/.*\.rb$/ - - !ruby/regexp /spec\/lib\/tasks(\/.*)*\/.*\.rb$/ - - !ruby/regexp /spec\/requests(\/.*)*\/.*\.rb$/ - - !ruby/regexp /spec\/routing(\/.*)*\/.*\.rb$/ - - !ruby/regexp /spec\/views(\/.*)*\/.*\.rb$/ - -RSpec/ExampleLength: - Description: Checks for long examples. - Enabled: false - -RSpec/ExampleWithoutDescription: - Description: Checks for examples without a description. - Enabled: false - -RSpec/HookArgument: - Description: Omit the default :each argument for RSpec hooks. - Enabled: false - -RSpec/MultipleExpectations: - Description: Checks if examples contain too many `expect` calls. - Enabled: false - -RSpec/NamedSubject: - Enabled: true - IgnoreSharedExamples: false - Description: Checks for explicitly referenced test subjects. - -RSpec/NestedGroups: - Enabled: true - Description: Checks for nested example groups. - Max: 4 - -RSpec/VerifiedDoubles: - Enabled: true - Description: Prefer using verifying doubles over normal doubles. - IgnoreSymbolicNames: true - -# Capybara - https://docs.rubocop.org/rubocop-rspec/cops_capybara.html - -RSpec/Capybara/FeatureMethods: - Description: Checks for consistent method usage in feature specs. - Enabled: false - -RSpec/InstanceVariable: - Description: Checks for instance variable usage in specs. - Enabled: false From 2ec0b6ee7d728a65cd513fb7c1dcb4159f7bbd2c Mon Sep 17 00:00:00 2001 From: Jim lesperance Date: Mon, 27 Nov 2023 16:11:21 +0100 Subject: [PATCH 2/2] release v0.8.1 --- CHANGELOG.md | 10 ++++++++++ lib/pactas_itero/version.rb | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3dc1b74..00b87cf 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,16 @@ # What's Changed +## [0.8.1] - 2023-11-27 + +### Changed + +- Update .circleci/config.yml + +### Removed + +- .rubocop.yml + ## Added - Add Metered Usage call by @3wille in https://github.com/shipcloud/billwerk/pull/146 diff --git a/lib/pactas_itero/version.rb b/lib/pactas_itero/version.rb index 8a44f25..ef9737f 100644 --- a/lib/pactas_itero/version.rb +++ b/lib/pactas_itero/version.rb @@ -1,5 +1,5 @@ # frozen_string_literal: true module PactasItero - VERSION = "0.8.0" + VERSION = "0.8.1" end