fix: allow model config update and single-model deletion#192
Merged
Conversation
- Allow saving an existing modelName to update its configuration instead of failing as a duplicate. - Allow deleting the last configured model and deleting the current main model. - Reassign model pointers to a remaining active model, or clear them when no models remain. - Add edit flow from Manage Model List so existing model parameters, including context length, can be changed directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
bun test tests/unit/model-manager-switching.test.ts tests/unit/model-selector.test.tsxbun run lintbun run format:checkNotes
bun run typecheckstill fails on unrelated existing Anthropic/diff type errors.bun teststill fails in this restricted environment due EPERM spawning cmd.exe/�un.exe/esbuild.exe and writing C:\Users\Administrator.kode.