Fix orphaned tool result UI fallback#188
Merged
Merged
Conversation
- Fix UI crash when rendering orphaned tool_result blocks whose tool_use_id no longer matches an assistant tool_use. - Keep provider/protocol handling strict; the fallback is limited to UI rendering. - Add a quiet fallback for successful tool results when tool lookup, tool renderer, or toolUseResult data is unavailable. - Keep rejected tool results on the existing rejection fallback when lookup/parsing fails. - Add Ink regression tests for orphaned success/rejected results and normal matched rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool_resultblocks whosetool_use_idno longer matches an assistanttool_use.toolUseResultdata is unavailable.Testing
bun test tests/unit/user-tool-result-message-orphaned.test.tsxbun test tests/unit/messages-ui-consistency.test.ts tests/unit/repl-static-split.test.ts tests/unit/session-load.test.tsbun run typecheckbun run lintbun run build:npmFull
bun testwas also run; unrelated Windows 5s timeouts occurred in filesystem permission/LSP tests. The affected files passed with:bun test --timeout 15000 tests/unit/file-permission-engine.test.ts tests/unit/lsp-tool.test.ts