fix(ci): Patch cask sha256 structurally to survive goreleaser format changes#144
Merged
Merged
Conversation
…changes The prior sed-based hash rewrite assumed the cask emitted `url ...` on one line and `sha256 ...` on the next. GoReleaser flipped the order between v0.2.0 and v0.2.1, so the sed silently no-ops and the cask carries the pre-JRE-bundling hash, which `brew install` rejects. Replace it with patch-cask-sha256.py: for each on_intel/on_arm block, read the archive filename from the url line, compute sha256 of the local JRE-bundled archive, and rewrite that block's sha256. Order-independent; exits non-zero on any anomaly (missing archive, missing sha256 line, no blocks at all) so a future silent format change cannot ship stale hashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prior sed-based hash rewrite assumed the cask emitted
url ...on one line andsha256 ...on the next. GoReleaser flipped the order between v0.2.0 and v0.2.1, so the sed silently no-ops and the cask carries the pre-JRE-bundling hash, whichbrew installrejects.Replace it with patch-cask-sha256.py: for each on_intel/on_arm block, read the archive filename from the url line, compute sha256 of the local JRE-bundled archive, and rewrite that block's sha256. Order-independent; exits non-zero on any anomaly (missing archive, missing sha256 line, no blocks at all) so a future silent format change cannot ship stale hashes.