fix(ci): Surface install.ps1 failures in test-install-ps1#143
Merged
Conversation
The Windows install test captured install.ps1 output into a variable but never printed it, then unconditionally indexed $matches[1]. When install.ps1 failed to emit OPENTAINT_BINARY_PATH (for any reason), the step failed with the cryptic "Cannot index into a null array" instead of the actual install.ps1 error. - Echo install.ps1 output before parsing it. - Throw on non-zero $LASTEXITCODE from install.ps1. - Throw a clear message when the regex match fails. - Trim captured path and write via $env:GITHUB_OUTPUT (the deprecated ::set-output workflow command was being used).
misonijnik
added a commit
that referenced
this pull request
May 15, 2026
The fixed 2s sleep before running install.ps1 was not reliable on the windows-latest runner: when the Python http.server had not started yet, the install script failed with "connection actively refused". The failure was masked until #143 surfaced install.ps1 exit codes. - Replace the fixed sleep with a 30s readiness poll that fails loudly and dumps the server log when the server never becomes reachable. - Add actions/setup-python so the runner has a known-good Python on PATH regardless of windows-latest image migrations. - Extract the duplicated server-startup and binary-verification logic into two composite actions (cli/serve-archive, cli/verify-installed-binary), used by all three install-test jobs. - Standardize on http://127.0.0.1:8080 across platforms. - Allow .github in .gitignore so the new composite actions are tracked despite the broad .* hidden-file rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows install test captured install.ps1 output into a variable but never printed it, then unconditionally indexed $matches[1]. When install.ps1 failed to emit OPENTAINT_BINARY_PATH (for any reason), the step failed with the cryptic "Cannot index into a null array" instead of the actual install.ps1 error.