Comment permalink with ?v=<comment version CID> renders not found on web

[ion-lion]

Bug

Seed web correctly generates a comment permalink with ?v=<comment-version-cid>, but rendering that URL returns a not-found error when the query param is present. The same comment URL loads correctly if the ?v= query param is removed.

Repro

Open this URL:

https://seedteamtalks.hyper.media/discussions/high-network-usage-in-activity-monitor/:comments/z6MkwRWdU6HY11Qzi9SQZrwSx3rxFw94ipYyiN7Dtbrcg2yU/z6GeWHYXTLa49x?v=bafy2bzacedjrx7zih3zlgvwhlvkpe3lmcvoa67ikvfrvfdqvf2ge4ky6nomhm

Observed: web shows a not found error.

Now remove the query param:

https://seedteamtalks.hyper.media/discussions/high-network-usage-in-activity-monitor/:comments/z6MkwRWdU6HY11Qzi9SQZrwSx3rxFw94ipYyiN7Dtbrcg2yU/z6GeWHYXTLa49x

Observed: comment loads correctly.

Expected behavior

The URL with ?v=bafy2bzacedjrx7zih3zlgvwhlvkpe3lmcvoa67ikvfrvfdqvf2ge4ky6nomhm should render the comment successfully. That CID is the latest comment version and is correct in the URL.

Notes

This looks like the web renderer/router may be interpreting v as a document version or otherwise applying it to the wrong resource when the route is a /:comments/<author>/<commentId> URL. For comment permalinks, v should be accepted as the comment version CID or ignored/fallback gracefully when resolving the comment by author/comment id.

[ion-lion]

Opened PR #573 with the proposed fix: #573

The branch treats ?v= on comment permalink routes as the comment version CID instead of a document version, so the target document lookup still resolves and the specific comment version is fetched separately.

[ion-lion]

Updated PR #573 with a real regression test and before/after proof.

New commit: ae883eb1f Add comment permalink route regression test

Verification now included in the PR body:

Before patch:

• Checked out parent/base 063b70c39
• Ran corepack pnpm --filter @shm/web test app/comment-permalink-route.test.ts
• Failed as expected: old route handling treated ?v=comment-version-cid as the target document version (version: "comment-version-cid", latest: false), which is the root of the not-found behavior.

After patch:

• Checked out fix/comment-version-permalink
• Ran the same focused web Vitest target
• Passed

Also passed:

• corepack pnpm --filter @shm/web exec prettier --check app/comment-permalink-route.test.ts
• git diff --check

Limitation: full dependency install hit an environment lifecycle failure building @sentry/profiling-node because make is missing, but the focused web test and formatting check ran successfully.

[horacioh]

Germinator triage

Root cause hypothesis: The catch-all Remix loader unconditionally treats the ?v= query parameter as the document version CID, so a comment permalink like /:comments/<author>/<commentId>?v=<comment-version-cid> causes the document fetch (loadResourceWithDiscovery) to look up the target document with a comment CID as its version, which yields a not-found error.

Likely files:

• frontend/apps/web/app/routes/$.tsx:259 — const version = url.searchParams.get('v') reads ?v= but does not differentiate between document and comment routes. This value is then injected into the document hmId at lines 318–322 and 337–341.
• frontend/apps/web/app/routes/$.tsx:318–341 — version (from ?v=) is passed to hmId() as the document version even when viewTerm === 'comments' and the path is a comment permalink. The resulting doc ID has version: <commentCID>, so loadResourceWithDiscovery fetches a non-existent document version.
• frontend/packages/shared/src/utils/entity-id-url.ts:229–249 — createCommentUrl produces URLs with ?v=<commentVersion>, correctly pinning the comment version in the permalink URL. This is the valid URL that triggers the bug.

Reproduction steps (expanded):

1. Navigate to any document with comments; copy a comment permalink (e.g. .../:comments/<author>/<commentId>?v=<comment-version-cid>).
2. Paste that URL and load it in the browser.
3. Observe: the page renders a not-found error.
4. Remove ?v=<comment-version-cid> from the URL and reload.
5. Observe: the comment loads correctly.

Plausible fix sketch:
In $.tsx, after viewTerm is determined from extractViewTermFromPath (line 329), add a conditional: when viewTerm === 'comments' and version is present, treat ?v= as the comment version rather than the document version. Specifically, pass the comment version through to loadSiteResource as a new param (e.g. commentVersion) and clear version / set latest: true for the document ID so the document resolves normally at head.

In loadSiteResource (loaders.ts:588–601), when openComment is set, pass the commentVersion through to getComment — getComment would need to accept an optional version parameter so it fetches the pinned comment version rather than the latest. The getComment function at loaders.ts:97–112 currently fetches a comment by ID string without a version; it would need a version-aware variant or an optional commentVersion argument forwarded to the gRPC call.

Severity: medium

---

A maintainer can comment /fix to have Gardener attempt this fix on a bot/fix-572 branch.

[ion-lion]

Thanks — this matches the fix I opened in #573.

That PR changes the web route handling so ?v= on /:comments/<author>/<commentId> is treated as the comment version CID, not as the target document version. It also includes a regression test that failed before the patch and passes after.