fix: remove passwords from dbsToImport#23
Open
sh-conet wants to merge 3 commits into
Open
Conversation
The user-supplied aaron_config.yml is mounted into /import and consumed by the CLI during conversion, but was never cleaned up afterwards - leaving the plaintext dbsToImport[].password lingering in the bind-mounted volume on the host once the import had run. aaron-import.sh now removes the password key(s) via `yq -i 'del(.dbsToImport[].password)'` on every exit path (after the CLI runs, and in the DB-exists / dump-found skip paths), while keeping the rest of the config intact and re-usable. The strip is guarded to only touch configs that actually contain a password, so comment-rich file-only configs stay byte-identical. The conversion's exit code is captured with `|| aaronExitCode=$?` so that a failed import does not abort the script under the neo4j entrypoint's `set -e` (`#!/bin/bash -eu`, sourced via EXTENSION_SCRIPT) before the password is stripped - verified in the container that a failed import now still strips the credential. Adds a committed bash test (AAroN-Docker/test/) that sources the real strip_credentials function via a source-guard and asserts the behavior (including a static guard for the errexit-safe pattern), using fixtures with a fake password. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strips .dbsToImport[].password from AARON_CONFIG