-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
compiletest: add a proper supports-crate-type: xxx directive #132309
Copy link
Copy link
Closed
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.Call for participation: Medium difficulty. Experience needed to fix: Intermediate.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Metadata
Metadata
Assignees
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.Call for participation: Medium difficulty. Experience needed to fix: Intermediate.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Type
Fields
Give feedbackNo fields configured for issues without a type.
Apparently
needs-dynamic-linkingis not equivalent to checking if dylib or cdylib crate types are supported.needs-dynamic-linkingperforms a check based on target cfg'sdynamic_linkingfield +--print=cfg --target $TARGET.only_cdylibwhich, ifdynamic_linkingistrue, indicates that onlycdylibcrate type is supported and notdylib.rust/compiler/rustc_target/src/spec/mod.rs
Lines 2148 to 2153 in f2becdf
wasmbase, dynamic linking is supported but notdylibcrate type, onlycdylibis supported.rust/compiler/rustc_target/src/spec/base/wasm.rs
Lines 58 to 62 in f2becdf
Originally posted by @jieyouxu in #130860 (comment)