build broken: dependency crossbeam-channel v0.3.9 fails to build

[matthiaskrgr]

When trying to build rls from the repo ( fb9aa9f ), the dependency crossbeam-channel v0.3.9 fails to build rendering rls unbuildable.

cargo +master check

    Checking crossbeam-channel v0.3.9
error[E0432]: unresolved import `crossbeam_utils::atomic`
 --> /home/matthias/.cargo/registry/src/github.com-1ecc6299db9ec823/crossbeam-channel-0.3.9/src/flavors/tick.rs:8:22
  |
8 | use crossbeam_utils::atomic::AtomicCell;
  |                      ^^^^^^ could not find `atomic` in `crossbeam_utils`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0432`.
error: could not compile `crossbeam-channel`.

[mati865]

It's not directly related to RLS: crossbeam-rs/crossbeam@5b5d727
Either crossbeam has to release update or RLS has to get rid of dependency enabling nightly feature of crossbeam crates (it's rustc-ap-rustc_data_structures 😞 ).

[Xanewok]

Oh no =( @mati865 I assume that means the rustc-ap-* upgrade dance all over again?

[mati865]

@Xanewok it depends whether crossbeam-utils fixes it in major/minor or patch release but in the long term the answer is yes.

As short term solution I've opened #1576
It works because older versions wasn't using target_has_atomic: crossbeam-rs/crossbeam@96ddd4d

[Xanewok]

cc crossbeam-rs/crossbeam#435

[Xanewok]

Merged upstream in rust-lang/rust#69470, now we need to coordinate a rustc-ap-* upgrade tomorrow (which will also unbreak the current RLS toolstate)