fix(review): address copilot review feedback on PR #257

- Use `is not None` instead of truthiness for env checks in serverless.py,
  serverless_cpu.py, and manifest.py so explicit env={} clears template env
- Add RUNPOD_API_KEY injection note to LB architecture doc
- Remove Claude-specific directive from plan doc

Author: deanq

docs/LoadBalancer_Runtime_Architecture.md

@@ -26,7 +26,7 @@ graph TD
 - Entrypoint: Loads manifest and starts FastAPI server on port 8000
 - Runpod exposes this via HTTPS endpoint URL
 - Health check: Runpod polls `/ping` every 30 seconds
-- Environment: `FLASH_MODULE_PATH` injected automatically, plus any explicit `env={}` vars
+- Environment: `FLASH_MODULE_PATH` injected automatically, `RUNPOD_API_KEY` injected when `makes_remote_calls=True`, plus any explicit `env={}` vars
 
 ### What Gets Deployed
 

docs/plans/2026-03-05-env-separation-plan.md

@@ -1,7 +1,5 @@
 # Env Separation Implementation Plan
 
-> **For Claude:** REQUIRED SUB-SKILL: Use superpowers:executing-plans to implement this plan task-by-task.
-
 **Goal:** Stop auto-carrying `.env` file contents to deployed endpoints; make resource `env={}` the sole source of user-declared deploy-time env vars.
 
 **Architecture:** Remove `EnvironmentVars` class and `get_env_vars()`. Change `ServerlessResource.env` default to `None`. Add deploy-time env preview table with secret masking. Update docs and examples.

src/runpod_flash/cli/commands/build_utils/manifest.py

@@ -239,7 +239,7 @@ def _extract_config_properties(config: Dict[str, Any], resource_config) -> None:
         if hasattr(resource_config, "locations") and resource_config.locations:
             config["locations"] = resource_config.locations
 
-        if hasattr(resource_config, "env") and resource_config.env:
+        if hasattr(resource_config, "env") and resource_config.env is not None:
             config["env"] = dict(resource_config.env)
 
         if (

src/runpod_flash/core/resources/serverless.py

@@ -551,7 +551,7 @@ def _configure_existing_template(self) -> None:
 
         if self.imageName:
             self.template.imageName = self.imageName
-        if self.env:
+        if self.env is not None:
             self.template.env = KeyValuePair.from_dict(self.env)
 
     async def _sync_graphql_object_with_inputs(

src/runpod_flash/core/resources/serverless_cpu.py

@@ -177,7 +177,7 @@ def _configure_existing_template(self) -> None:
 
         if self.imageName:
             self.template.imageName = self.imageName
-        if self.env:
+        if self.env is not None:
             self.template.env = KeyValuePair.from_dict(self.env)
 
         # Apply CPU-specific disk sizing