feat: import aliases setting and glob pattern resolution#2
Merged
Conversation
…ution Add configurable importAliases (map[string]string) to settings so that workspace package imports like @scope/shared-ui/images/icon.svg resolve to their actual repo paths (packages/shared-ui/images/icon.svg). Backend: resolveAlias with longest-prefix matching in Resolve and fuzzy match, rewriteSpecifier preserves alias format during optimization apply, aliases plumbed through ScanOptions and scanner.Project. Frontend: key-value editor in ScanningSection, alias changes trigger rescan via settingsCatalogInputsChanged. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Pattern references like ./images/**/*.avif were matched by literal suffix comparison which always failed for ** and * wildcards. Add resolvePattern to expand the relative/alias base path while preserving glob characters, then match candidates with the existing matchPathParts glob engine. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for custom import aliases, allowing users to map package names to repository paths for accurate reference resolution. The changes span the Go backend (updating path resolution, reference scanning, and settings storage) and the React frontend (adding a UI section to manage import aliases). The review feedback highlights two key areas for improvement: first, sanitizing alias keys and values in Go (e.g., trimming slashes) to prevent malformed paths; second, avoiding the use of array indices as React keys in the settings UI by introducing unique IDs for alias entries in the draft state.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Trim leading/trailing slashes from alias keys and values in resolveAlias and rewriteSpecifier to prevent double-slash or mismatched paths from user input. Use filepath.Clean for robust path normalization. Replace array index with unique id for import alias React list keys to avoid DOM reuse glitches on add/delete. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
runkids
added a commit
that referenced
this pull request
Jun 9, 2026
Manual importAliases alone forces users to re-declare aliases their projects already define in tsconfig/jsconfig paths and vite/next resolve.alias. Detect those at scan time and merge them into the same resolution map as the base layer, with manual entries overriding on key collision, so reference resolution works zero-config for the common case. - internal/aliasdetect: read tsconfig/jsconfig paths (baseUrl, relative extends chain) and vite/next resolve.alias (object + array forms, unwrapping path.resolve/fileURLToPath), normalized to repo-relative - wire detection into scanner reference building and action-rewrite paths - expose GET /api/settings/detected-aliases and surface detected aliases read-only in Scanning settings, grouped by project, marking entries overridden by the manual table - fill ja/ko/zh-CN import-alias keys (PR #2 only added en/zh-TW) and add detected-alias keys across all five locales - fix helpers.test.ts fixture missing importAliases that broke ui build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
importAliasessetting (map of package name → repo path) so workspace package imports like@scope/shared-ui/images/icon.svgresolve to their actual repo pathsimport.meta.globpatterns (**/*.avif) by expanding relative/alias base paths and matching with the existingmatchPathPartsglob engineScreenshots
Test plan
TestResolveWithImportAliases— alias prefix matching, boundary check, fallbackTestBuildMapResolvesImportAliases— end-to-end alias reference detectionTestBuildMapResolvesGlobPattern—import.meta.globwith**/*.avifmatches multiple assetsTestPathAndSpecifierHelpers—rewriteSpecifierpreserves alias format + query strings