You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
engine/crates/rocky-adapter-sdk/src/conformance.rs::run_conformance currently iterates every TestSpec and marks all supported tests as Passed with zero duration. #383 wires one real trait call (SqlDialect::format_table_ref). This issue is the next deliberately narrow slice: wire one more trait call so the runner exercises another adapter method against a real fixture.
Depends on #383 — read its merged PR as your template; this issue follows the same shape with one different trait.
Scope
When the spec name is "batch_row_counts", invoke BatchCheckAdapter::row_counts(...) against a stub TableRef (or stub adapter) and assert the returned counts vector is non-empty. Leave the other ~25 specs on the current Passed-stub path — follow-up issues will wire them incrementally.
Stronger assertions are adapter-specific — keep this first wiring simple.
Code refs
engine/crates/rocky-adapter-sdk/src/conformance.rs:282-286 — the batch_row_counts spec entry
engine/crates/rocky-adapter-sdk/src/conformance.rs::run_conformancecurrently iterates everyTestSpecand marks all supported tests asPassedwith zero duration. #383 wires one real trait call (SqlDialect::format_table_ref). This issue is the next deliberately narrow slice: wire one more trait call so the runner exercises another adapter method against a real fixture.Scope
When the spec name is
"batch_row_counts", invokeBatchCheckAdapter::row_counts(...)against a stubTableRef(or stub adapter) and assert the returned counts vector is non-empty. Leave the other ~25 specs on the currentPassed-stub path — follow-up issues will wire them incrementally.Stronger assertions are adapter-specific — keep this first wiring simple.
Code refs
engine/crates/rocky-adapter-sdk/src/conformance.rs:282-286— thebatch_row_countsspec entryengine/crates/rocky-adapter-sdk/src/conformance.rs:309—run_conformancesignatureengine/crates/rocky-adapter-sdk/src/conformance.rs:337-348— the "all supported tests marked Passed" placeholder blockengine/crates/rocky-adapter-sdk/src/traits.rs—BatchCheckAdapter::row_countsAcceptance criteria
run_conformanceinvokesBatchCheckAdapter::row_countsfor thebatch_row_countsspec onlyPassed-stub pathcargo test -p rocky-adapter-sdkis greendocs/src/content/docs/guides/adapter-sdk.mdgains a one-line note thatbatch_row_countsis now wired, matching the style of the note added in Wire one trait call into rocky-adapter-sdk conformance runner #383Effort
2–3 hours. The bigger trait-unification work is deliberately out of scope.