Discovery script not working with CentOS 6.8-6.10 with php 5.3.3

[gadg3ts]

I have this running for a suite of (legacy) CentOS machines ranging from 5.6 to 6.7 (not my fault. I've just inherited looking after them). I managed to get them all running php 5.3.3 for this to work.
However, the host machines where the discovery script ISN'T working (CentOS 6.8-6.10) have in common versions of xen-hypervisor that is 4.6+ (4.6.3, 4.9.1, 4.9.3) where the output of "xm list -l" is somewhat different.

Which appears to be confusing the script when it is looking to fill the arrays, erroring with:
PHP Notice: Undefined index: name-label in /etc/zabbix/scripts/parse_vm_list_xen.php on line 134
PHP Notice: Undefined index: uuid in /etc/zabbix/scripts/parse_vm_list_xen.php on line 150
PHP Notice: Undefined index: name-label in /etc/zabbix/scripts/parse_vm_list_xen.php on line 149

[rivoduck]

Unfortunately I am not maintaining the xen hypervisor version of these scripts since I do not have any Xen installation (only Xen Server).
If you manage to adapt it I would be happy to integrate the changes!

Andrea

[gadg3ts]

I think I've figured out what the problem is.
It might be a bug in xen...
In the xm list outputs that aren't reporting back properly (the 'newest' ones), the output for Domain-0 contains an extra closing bracket, so resulting in the json output spreading a single name/uuid pair over two entries.

(domain
        (domid 0)
        (create_info)
        (hvm 0)
        (hap <default>)
        (oos <default>)
        (ssidref 0)
        (name Domain-0)
        (uuid 00000000-0000-0000-0000-000000000000)
        (xsdata (null))
        (platformdata (null))
        (build_info)
        (max_vcpus 0)
        (tsc_mode default)
        (max_memkb 4194304)
        (target_memkb 2097151)
        (nomigrate <default>)
        (image
                (linux 0)
                        (kernel (null))
                        (cmdline (null))
                        (ramdisk (null))
                        (e820_host <default>)
                )
        )
)

So (according to vim) the closing bracket for '(domain' is actually the second-to-last one...
So it's probably not your problem ;)