Abnormal disconnections lock out players from rejoining

[sg4e]

When a player experiences an abnormal disconnection (such as from an Internet outage or a lag spike) while making a move, the game can enter a state where the player's seat is still marked as occupied, and when reconnecting, the player is unable to reclaim their seat. In this state, the game cannot be completed, and a new room must be created with the current hand lost.

The upstream repo has fixed this scenario by implementing an "Unseat" button, see commits:

• pwmarcz@87fc565
• pwmarcz@0d96e47

Is it possible to merge these commits to solve this issue?

[riichinomics]

Yes, this is a well known issue to me. We have this happen regularly. Eventually the server removes the inactive player. Unfortunately this fork has diverged from the upstream significantly and I'm not sure if we can simply cherry pick those commits, but I plan to resolve this issue in a series of upcoming changes. If you want to try and cherry pick the commits your self feel free. I will review the changes and deploy them if they work.

[5zlotych]

Hi, I noticed that problem yesterday and it was pretty frustrating. Just a little bump up so you remember about that, It'd be great if it got fixed 😔

[riichinomics]

I've added some heartbeat logic to the server to clear dead connections. Hopefully it should resolve this issue, but I will keep it open for now.