Skip to content
This repository was archived by the owner on Jul 11, 2022. It is now read-only.

Allow classloader to be passed into EMS advanced properties#4

Closed
genman wants to merge 1 commit into
rhq-project:masterfrom
genman:P136
Closed

Allow classloader to be passed into EMS advanced properties#4
genman wants to merge 1 commit into
rhq-project:masterfrom
genman:P136

Conversation

@genman

@genman genman commented Jul 7, 2014

Copy link
Copy Markdown

Removes an unnecessary cast

Example:

ClassLoader ccl = Thread.currentThread().getContextClassLoader();
Properties p = new Properties();
p.put(JMXConnectorFactory.DEFAULT_CLASS_LOADER, ccl);

ConnectionSettings connectionSettings = new ConnectionSettings();
connectionSettings.setAdvancedProperties(p);
ConnectionFactory connectionFactory = new ConnectionFactory();
ConnectionProvider connectionProvider = connectionFactory.getConnectionProvider(connectionSettings);

Removes an unnecessary cast

Example:

ClassLoader ccl = Thread.currentThread().getContextClassLoader();
Properties p = new Properties();
p.put(JMXConnectorFactory.DEFAULT_CLASS_LOADER, ccl);

ConnectionSettings connectionSettings = new ConnectionSettings();
connectionSettings.setAdvancedProperties(p);
ConnectionFactory connectionFactory = new ConnectionFactory();
ConnectionProvider connectionProvider = connectionFactory.getConnectionProvider(connectionSettings);
@metlos

metlos commented Oct 23, 2014

Copy link
Copy Markdown

How is this used?

@genman

genman commented Oct 23, 2014

Copy link
Copy Markdown
Author

I used it to fix the classloader issue I saw with connecting to JBoss AS 7 JMX. But you figured out another way to do this...The change isn't really necessary but doesn't hurt either.

@genman

genman commented Oct 23, 2014

Copy link
Copy Markdown
Author

Actually the change is redundant with Bug/1146167

@metlos

metlos commented Oct 23, 2014

Copy link
Copy Markdown

Ok, so based on @genman 's comment, I think we can close this in favor of #5. Who has rights to do that @pilhuhn?

@genman

genman commented Oct 23, 2014

Copy link
Copy Markdown
Author

I'll close it.

@genman genman closed this Oct 23, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants