Skip to content

Fix cuDF TPC-H benchmark properties flag #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 1 commit into from
May 18, 2026
Merged

Fix cuDF TPC-H benchmark properties flag #348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions velox/benchmarks/tpch.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ run_tpch_single_benchmark() {
local num_repeats="$5"

printf -v query_number_padded '%02d' "$query_number"
cudf_memory_resource="async"

# Set device-specific parameters
case "$device_type" in
Expand All @@ -188,9 +189,8 @@ run_tpch_single_benchmark() {
num_drivers=${NUM_DRIVERS:-4}
cudf_chunk_read_limit=$((1024 * 1024 * 1024 * 1))
cudf_pass_read_limit=0
cudf_memory_resource="async"
BENCHMARK_EXECUTABLE="$(get_tpch_benchmark_executable_path "$device_type")"
CUDF_FLAGS="--cudf_chunk_read_limit=${cudf_chunk_read_limit} --cudf_pass_read_limit=${cudf_pass_read_limit} --cudf_memory_resource=${cudf_memory_resource}"
CUDF_FLAGS="--cudf_chunk_read_limit=${cudf_chunk_read_limit} --cudf_pass_read_limit=${cudf_pass_read_limit}"
;;
esac

Expand Down Expand Up @@ -226,14 +226,21 @@ run_tpch_single_benchmark() {
$run_in_container_func 'bash -c "
set -exuo pipefail
BASE_FILENAME=\"benchmark_results/q'"${query_number_padded}"'_'"${device_type}"'_'"${num_drivers}"'_drivers\"
if [[ '"${device_type}"' == "gpu" ]]; then
CUDF_PROPERTIES_FILE=\"$(mktemp /tmp/velox-cudf.XXXXXX.properties)\"
printf "%s\\n" "cudf.memory_resource='"${cudf_memory_resource}"'" > \"\${CUDF_PROPERTIES_FILE}\"
CUDF_FLAGS=\"'"${CUDF_FLAGS}"' --cudf_properties=\${CUDF_PROPERTIES_FILE}\"
else
CUDF_FLAGS=\"'"${CUDF_FLAGS}"'\"
fi
'"${PROFILE_CMD}"' \
'"${BENCHMARK_EXECUTABLE}"' \
--data_path=/workspace/velox/velox-benchmark-data \
--data_format=parquet \
--run_query_verbose='"${query_number_padded}"' \
--num_repeats='"${num_repeats}"' \
--num_drivers='"${num_drivers}"' \
'"${CUDF_FLAGS}"' 2>&1 | \
\${CUDF_FLAGS} 2>&1 | \
tee \"\$BASE_FILENAME\"
chown \"${USER_ID}:${GROUP_ID}\" \"\$BASE_FILENAME\"
NSYS_REP_FILE=\"\${BASE_FILENAME}.nsys-rep\"
Expand Down
Loading