Fix how tests are executed#1028
Merged
rapids-bot[bot] merged 5 commits intoMay 22, 2026
Merged
Conversation
Before this test, it was possible for a test to "pass" without actually meeting the required conditions. If a `SHOULD_FAIL` argument was passed with a regular expression, and the test was supposed to have an exit code of 0 and have stdout or stderr that matches the regular expression, but in reality it had an exit code of 1 without matching the regular expression, it would pass. Change test execution so that the conditions are checked more carefully. Use a test script to do these checks.
KyleFromNVIDIA
added
bug
bdice
approved these changes
May 22, 2026
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before this change, it was possible for a test to "pass" without actually meeting the required conditions. If a
SHOULD_FAILargument was passed with a regular expression, and the test was supposed to have stdout or stderr that matches the regular expression, but in reality it had an exit code of 1 without matching the regular expression, it would pass. Change test execution so that the conditions are checked more carefully. Use a test script to do these checks.Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))