rapids_find_generate_module: Support a custom TARGET_NAME#1027
Closed
chuckatkins wants to merge 4 commits into
Closed
rapids_find_generate_module: Support a custom TARGET_NAME#1027chuckatkins wants to merge 4 commits into
chuckatkins wants to merge 4 commits into
Conversation
The existing INITIAL_CODE_BLOCK and FINAL_CODE_BLOCK arguments are populated before the any find_path or find_library calls and after target creation respectively. This introduces a new PRE_FPHSA_CODE_BLOCK argument that gets populated after the find_* calls but before find_package_handle_standard_args. The new argument is particulary useful for providing things like custom code to parse version information from header files for find_package_handle_standard_args to consider.
Useful when a project has both a CMake and non-CMake build and the package config file for the CMake build creates a different target than <PackageName>::<PackageName> (e.g. <PackagName>::<package_name>), so using the generated find module to find the non-CMake build will produce the same output as finding the CMake package config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
rapids_find_generate_module: Support a customTARGET_NAMEUseful when a project has both a CMake and non-CMake build and the package config file for the CMake build creates a different target than
<PackageName>::<PackageName>(e.g.<PackagName>::<package_name>). Using theTARGET_NAMEargument allows the generated find module to locate the non-CMake build produce the same output as locating the CMake build with and importing it's CMake package config.Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))