Remove requirement to specify project name to cuda_init_architectures#1017
Open
robertmaynard wants to merge 5 commits into
Open
Remove requirement to specify project name to cuda_init_architectures#1017robertmaynard wants to merge 5 commits into
robertmaynard wants to merge 5 commits into
Conversation
Contributor
Author
|
/okay to test |
robertmaynard
force-pushed
the
fea/remove_project_name_from_cuda_init
branch
from
1b11a79 to
d42b537
Compare
Contributor
Author
|
/okay to test |
robertmaynard
force-pushed
the
fea/remove_project_name_from_cuda_init
branch
from
d42b537 to
5b09556
Compare
robertmaynard
added
feature request
robertmaynard
force-pushed
the
fea/remove_project_name_from_cuda_init
branch
from
5b09556 to
30c7727
Compare
robertmaynard
force-pushed
the
fea/remove_project_name_from_cuda_init
branch
from
30c7727 to
4570302
Compare
robertmaynard
force-pushed
the
fea/remove_project_name_from_cuda_init
branch
from
8845bb2 to
611e624
Compare
vyasr
approved these changes
May 15, 2026
Contributor
vyasr
left a comment
vyasr
left a comment
There was a problem hiding this comment.
Implementation looks fine.
| unset(CMAKE_CUDA_ARCHITECTURES) | ||
| unset(ENV{CUDAARCHS}) | ||
|
|
||
| rapids_cuda_init_architectures(rapids-project) |
Contributor
There was a problem hiding this comment.
Why change this test if you already have a new test with no project value?
Contributor
Author
There was a problem hiding this comment.
I wanted to have tests that cover that the RAPIDS and NATIVE modes work as expected with the no project syntax.
vyasr
approved these changes
May 21, 2026
| function(rapids_cuda_set_architectures mode) | ||
| list(APPEND CMAKE_MESSAGE_CONTEXT "rapids.cuda.set_architectures") | ||
|
|
||
| if(NOT DEFINED CMAKE_CUDA_COMPILER_ID) |
Contributor
There was a problem hiding this comment.
I'll trust you that this check is the best option for verifying that the CUDA language is enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Relax requirements for
rapids_cuda_init_architecturesso users don't need to keep 2 sources of truth in sync for the project name.Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))