Refactor group_nunique.cu to use nullate::DYNAMIC for reduce-by-key functor#11482
Merged
rapids-bot[bot] merged 3 commits intoAug 5, 2022
Merged
Conversation
Contributor
Author
|
The benchmark from #11472 was used to check the change in performance. All diffs are less than 2% |
bdice
approved these changes
Aug 5, 2022
Contributor
bdice
left a comment
There was a problem hiding this comment.
I have to say, I love nullate::DYNAMIC. Such a nice solution.
hyperbolic2346
approved these changes
Aug 5, 2022
PointKernel
approved these changes
Aug 5, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.10 #11482 +/- ##
===============================================
Coverage ? 86.47%
===============================================
Files ? 144
Lines ? 22856
Branches ? 0
===============================================
Hits ? 19765
Misses ? 3091
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored the
group_nunique.cusource to use thenullate::DYNAMICfor the equal operator and the unique-iterator. This improves the compile time by almost 2x without much change to performance by reducing the number of calls tothrust::reduce_by_key.Found while investigating compile issues for #11437
Checklist