Add missing Thrust #includes.#11457
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.10 #11457 +/- ##
===============================================
Coverage ? 86.47%
===============================================
Files ? 144
Lines ? 22856
Branches ? 0
===============================================
Hits ? 19764
Misses ? 3092
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
That would be nice. I don't have a way to do that right now, but perhaps I can alter my script to remove all Thrust headers and re-add only those that the file actually uses. We can't make use of tooling like iwyu (I think it requires clang compatibility and does not support CUDA) but we can try the approach with my header fixer script. |
|
@gpucibot merge |
Updates the bundled version of Thrust to 1.17.0. I will run benchmarks and include results in a comment below. Depends on #11457. Supersedes #10489, #10577, #10586. Closes #10841. **This should be merged concurrently with rapidsai/rapids-cmake#231 Authors: - Bradley Dice (https://github.com/bdice) Approvers: - David Wendt (https://github.com/davidwendt) - Nghia Truong (https://github.com/ttnghia) - Robert Maynard (https://github.com/robertmaynard) URL: #11437
Description
Thrust 1.16 removed internal header inclusions that libcudf relied on. This PR adds missing
#includes that were found automatically by a script I wrote. See notes on #10489. This was previously applied in #10489 but the script became more sophisticated (and libcudf has changed) since I last applied it, so more missing#includes were found.Required for #11437 to upgrade to Thrust 1.17. This change has been separated from #11437 to minimize that PR's diff. Some additional changes will be needed on that PR but we don't want to hold off on fixing these includes, as recommended by @davidwendt.
Checklist