feat: use Newt in dev-env#2322
Draft
anmazzotti wants to merge 1 commit into
Draft
Conversation
021b327 to
adc692c
Compare
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
adc692c to
c88d597
Compare
Contributor
Author
|
Blocked waiting for a Pangolin instance to be used. |
Contributor
Author
|
Blocked waiting for EDR approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix #2283
This PR replaces ngrok with newt.
Changes:
CATTLE_CHART_*variables, this prevents a Rancher pod restart and makes the deployment more production-likekindmanagement environment type has been removed due to lack of usage and maintenanceUsage:
PANGOLIN_ENDPOINT=my.pangolin.example.com \ NEWT_SITE_ID=my-newt-client-id \ NEWT_SITE_SECRET=my-newt-client-secret \ PANGOLIN_SITE_DOMAIN=myself.myteam.my.pangolin.example.com \ PANGOLIN_SITE_IDENTIFIER=some-random-identifier \ make dev-envAbout NetworkPolicy:
This is a requirement of the RFD.
In this context it's a bit overkill, because the newt pod can't escape the kind container and it's just a dev environment. Right now this does not seem to cause any critical errors in newt.
There's a 10 seconds timeout during boot, but it's not critical.
See newt logs:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: