Skip to content

Remove knowledge of tests from code #112

@rafecolton

Description

@rafecolton

There are a couple places where the app code had to know about testing to prevent bad things from happening. This was also done to avoid putting the tests in the given package instead of the _test version.

However, requiring the application to know about the tests is bad. So that needs to be fixed.

This is done with the TestMode var in package job and webhook and with isRegular on the Builder struct. Likely, the whole code base needs to be audited for this pattern.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions