Fix CP slice parallel state access#1185
Merged
yushengsu-thu merged 1 commit intoMay 24, 2026
Merged
Conversation
kaixih
requested review from
Zhichenzzz,
fzyzcjy,
maocheng23 and
yueming-yuan
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the slice_with_cp function in miles/backends/training_utils/cp_utils.py to access context parallel rank and size through a nested cp object within parallel_state rather than using direct attributes. I have no feedback to provide as there were no review comments.
yushengsu-thu
approved these changes
May 24, 2026
Collaborator
yushengsu-thu
left a comment
yushengsu-thu
left a comment
There was a problem hiding this comment.
@guapisolo I also encounter the same problem. This should fix ~
fzyzcjy
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@guapisolo