Rocm changes to tests/e2e/megatron/test_glm5_744b_a40b_4layer.py#1172
Open
sreerohi wants to merge 1 commit into
Open
Rocm changes to tests/e2e/megatron/test_glm5_744b_a40b_4layer.py#1172sreerohi wants to merge 1 commit into
sreerohi wants to merge 1 commit into
Conversation
sreerohi
changed the title
sreerohi
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces ROCm support for the GLM-5 4-layer model end-to-end test. It implements environment detection using torch.version.hip to conditionally configure execution parameters, including switching the NSA backend to tilelang, reducing the SGLang page size, and utilizing the alltoall token dispatcher for MoE when running on ROCm. I have no feedback to provide.
…ark#1122 , radixark#1123): - Drop DeepEP; use alltoall dispatcher - Swap flashmla_sparse NSA backend for tilelang - Set sglang-page-size to 1 (required by tilelang NSA)
sreerohi
force-pushed
the
rocm/glm5_744b_a440_4layer_changes
branch
from
589c5f0 to
5540524
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1122 and #1123
Relates to #1105