Bump sglang to v0.5.12#1164
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This reverts commit 5464245.
yueming-yuan
requested review from
Zhichenzzz,
jybsuper,
maocheng23 and
yushengsu-thu
as code owners
guapisolo
approved these changes
May 22, 2026
Collaborator
guapisolo
left a comment
guapisolo
left a comment
There was a problem hiding this comment.
CI modifications and TITO test changes LGTM.
maocheng23
approved these changes
May 22, 2026
Contributor
maocheng23
left a comment
maocheng23
left a comment
There was a problem hiding this comment.
Overall LGTM, only NITs.
|
|
||
| # Setup Ring Flash Attention with CP group from mesh (only when cp_size > 1) | ||
| if cp_size > 1: | ||
| from ring_flash_attn import substitute_hf_flash_attn |
| position_ids = batch["position_ids"] | ||
|
|
||
| if get_parallel_state().cp.size > 1: | ||
| from ring_flash_attn import update_ring_flash_attn_params |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci-sglang-pr: sglang-miles-v0.5.12
ci-image-tag: sglang-miles-v0.5.12
Summary
lmsysorg/sglang:v0.5.12-cu129by default.sglang-miles-v0.5.12.yueming-yuan/miles-wheels:cu129-x86_64-v0.5.12so flash-attn 2 matches the torch 2.11/cu129 ABI.v0.5.12-cu130.SGLang migration
sgl-project/sglang:sglang-miles-v0.5.12rebased on upstreamv0.5.12.v0.5.12where applicable.Wheels
TORCH_CUDA_ARCH_LIST=8.0;8.6;8.9;9.0;10.0;10.3.TODO
ring_flash_attnto fix FSDP CP path.Local checks
pre-commit run --all-fileson the rebased sglang branchpython3 -m compileallon conflict-touched sglang filesgit diff --checkin milesRemote build check
rcli job new --dockerfile docker/Dockerfile --build-context /home/radixark/miles-bump-sglang-v0.5.12-context --server ion-user-7 --name bump-sglang-v0.5.12-testyueming.yuan-bump-sglang-v0.5.12-testsglangandtorch; sglang checkout HEAD isa4202a8