From 593bb1c78fb5d8e33209b94bb9e3c7d707246676 Mon Sep 17 00:00:00 2001 From: mhucka <1450019+mhucka@users.noreply.github.com> Date: Thu, 26 Mar 2026 03:04:33 +0000 Subject: [PATCH 1/2] =?UTF-8?q?=F0=9F=A7=AA=20Add=20unit=20test=20for=20QS?= =?UTF-8?q?imSimulator.get=5Fseed?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Added a new test case `test_get_seed` to `qsimcirq_tests/qsimcirq_test.py` to verify: - The returned seed is within the expected [0, 2^31 - 1) range. - The simulator is deterministic when initialized with a fixed seed. - Subsequent calls to `get_seed` return different values. --- qsimcirq_tests/qsimcirq_test.py | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/qsimcirq_tests/qsimcirq_test.py b/qsimcirq_tests/qsimcirq_test.py index 0b5cdbc8e..6cd2fee7f 100644 --- a/qsimcirq_tests/qsimcirq_test.py +++ b/qsimcirq_tests/qsimcirq_test.py @@ -2196,3 +2196,20 @@ def test_1d_representation(): want = np.array([0.0 - 0.5j, 0.0 + 0.5j, 0.0 - 0.5j, 0.0 + 0.5j]) _, res, _ = qsim_sim.simulate_into_1d_array(c) np.testing.assert_allclose(res, np.array(want, dtype=np.complex64)) + + +def test_get_seed(): + # Test range. + qsim_sim = qsimcirq.QSimSimulator(seed=42) + for _ in range(100): + seed = qsim_sim.get_seed() + assert 0 <= seed < 2**31 - 1 + + # Test determinism. + sim1 = qsimcirq.QSimSimulator(seed=42) + sim2 = qsimcirq.QSimSimulator(seed=42) + assert sim1.get_seed() == sim2.get_seed() + + # Test subsequent calls. + sim = qsimcirq.QSimSimulator(seed=42) + assert sim.get_seed() != sim.get_seed() From f98aea84b991fa5a8ed0866e0def96114ec768da Mon Sep 17 00:00:00 2001 From: Michael Hucka Date: Wed, 25 Mar 2026 20:10:20 -0700 Subject: [PATCH 2/2] Update qsimcirq_tests/qsimcirq_test.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --- qsimcirq_tests/qsimcirq_test.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qsimcirq_tests/qsimcirq_test.py b/qsimcirq_tests/qsimcirq_test.py index 6cd2fee7f..215407e8f 100644 --- a/qsimcirq_tests/qsimcirq_test.py +++ b/qsimcirq_tests/qsimcirq_test.py @@ -2212,4 +2212,5 @@ def test_get_seed(): # Test subsequent calls. sim = qsimcirq.QSimSimulator(seed=42) - assert sim.get_seed() != sim.get_seed() + seeds = {sim.get_seed() for _ in range(10)} + assert len(seeds) > 1