chore(rust): apply clippy auto-fixes for remaining files

- Fix unused variables in audio.rs, settings.rs, scanner files, watcher.rs
- Apply clippy suggested fixes automatically

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: pythoninthegrass

src-tauri/src/commands/audio.rs

@@ -149,8 +149,8 @@ fn audio_thread(rx: Receiver<AudioCommand>, app: AppHandle) {
                && play_count_state.track_id.is_some() {
                 let ratio = progress.position_ms as f64 / progress.duration_ms as f64;
 
-                if ratio >= 0.75 {
-                    if let Some(track_id) = play_count_state.track_id {
+                if ratio >= 0.75
+                    && let Some(track_id) = play_count_state.track_id {
                         // Spawn async task to avoid blocking audio thread
                         let app_handle = app.clone();
                         std::thread::spawn(move || {
@@ -165,7 +165,6 @@ fn audio_thread(rx: Receiver<AudioCommand>, app: AppHandle) {
                         });
                         play_count_state.threshold_reached = true;
                     }
-                }
             }
 
             // Check scrobble threshold (90% default, configurable)
@@ -174,8 +173,8 @@ fn audio_thread(rx: Receiver<AudioCommand>, app: AppHandle) {
                && scrobble_state.track_id.is_some() {
                 let ratio = progress.position_ms as f64 / progress.duration_ms as f64;
 
-                if ratio >= scrobble_state.threshold_percent {
-                    if let Some(track_id) = scrobble_state.track_id {
+                if ratio >= scrobble_state.threshold_percent
+                    && let Some(track_id) = scrobble_state.track_id {
                         // Spawn async task to avoid blocking audio thread
                         let app_handle = app.clone();
                         std::thread::spawn(move || {
@@ -193,7 +192,6 @@ fn audio_thread(rx: Receiver<AudioCommand>, app: AppHandle) {
                         });
                         scrobble_state.threshold_reached = true;
                     }
-                }
             }
         }
 

src-tauri/src/commands/settings.rs

@@ -86,11 +86,10 @@ pub fn settings_get_all(app: AppHandle) -> Result<AllSettingsResponse, String> {
 
     // Also include any extra keys that might be in the store
     for key in store.keys() {
-        if !settings.contains_key(&key) {
-            if let Some(value) = store.get(&key) {
+        if !settings.contains_key(&key)
+            && let Some(value) = store.get(&key) {
                 settings.insert(key, value.clone());
             }
-        }
     }
 
     Ok(AllSettingsResponse { settings })

src-tauri/src/scanner/artwork.rs

@@ -85,8 +85,8 @@ pub fn get_folder_artwork(filepath: &str) -> Option<Artwork> {
     // Try exact filenames first
     for filename in ARTWORK_FILENAMES {
         let artwork_path = folder.join(filename);
-        if artwork_path.exists() {
-            if let Ok(data) = fs::read(&artwork_path) {
+        if artwork_path.exists()
+            && let Ok(data) = fs::read(&artwork_path) {
                 let ext = artwork_path.extension()?.to_str()?.to_lowercase();
                 let mime_type = match ext.as_str() {
                     "jpg" | "jpeg" => "image/jpeg",
@@ -103,7 +103,6 @@ pub fn get_folder_artwork(filepath: &str) -> Option<Artwork> {
                     filename: Some(filename.to_string()),
                 });
             }
-        }
     }
 
     // Try case-insensitive search

src-tauri/src/scanner/commands.rs

@@ -148,8 +148,8 @@ pub async fn scan_paths_to_library(
                 }
             }
 
-            if !was_reconciled {
-                if let Ok(hash) = compute_content_hash(std::path::Path::new(&m.filepath)) {
+            if !was_reconciled
+                && let Ok(hash) = compute_content_hash(std::path::Path::new(&m.filepath)) {
                     let track_result = library::find_missing_track_by_content_hash(&conn, &hash);
                     if let Ok(Some(track)) = track_result {
                         let reconcile_result = library::reconcile_moved_track(&conn, track.id, &m.filepath, m.file_inode);
@@ -159,7 +159,6 @@ pub async fn scan_paths_to_library(
                         }
                     }
                 }
-            }
 
             if !was_reconciled {
                 truly_new.push((m.filepath.clone(), to_db_metadata(m)));
@@ -187,11 +186,10 @@ pub async fn scan_paths_to_library(
     // Clear missing flag for unchanged files that were previously missing but have reappeared
     // This handles the case where a file is moved out and then moved back to the same location
     let mut recovered_count = 0;
-    if !scan_result.unchanged.is_empty() {
-        if let Ok(count) = library::mark_tracks_present_by_filepaths(&conn, &scan_result.unchanged) {
+    if !scan_result.unchanged.is_empty()
+        && let Ok(count) = library::mark_tracks_present_by_filepaths(&conn, &scan_result.unchanged) {
             recovered_count = count;
         }
-    }
 
     let duration_ms = start_time.elapsed().as_millis() as u64;
 

src-tauri/src/watcher.rs

@@ -491,8 +491,8 @@ impl WatcherManager {
                         }
                     }
 
-                    if !was_reconciled {
-                        if let Ok(hash) = compute_content_hash(std::path::Path::new(&m.filepath)) {
+                    if !was_reconciled
+                        && let Ok(hash) = compute_content_hash(std::path::Path::new(&m.filepath)) {
                             let track_result = library::find_missing_track_by_content_hash(&conn, &hash);
                             if let Ok(Some(track)) = track_result {
                                 let reconcile_result = library::reconcile_moved_track(
@@ -511,7 +511,6 @@ impl WatcherManager {
                                 }
                             }
                         }
-                    }
 
                     if !was_reconciled {
                         truly_new.push((m.filepath.clone(), to_track_metadata(m)));